Skip to content

Analog Input Update#3

Open
Sral931 wants to merge 6 commits intoreef-pi:mainfrom
Sral931:AnalogInputUpdate
Open

Analog Input Update#3
Sral931 wants to merge 6 commits intoreef-pi:mainfrom
Sral931:AnalogInputUpdate

Conversation

@Sral931
Copy link

@Sral931 Sral931 commented Jan 6, 2023

Implemented features as described on Reef2Reef.com:

  • FlowMeter compatibility
  • Robo-Tank PH circuit compatibility
  • extended AnalogInput ID handling
    As well as other improvements:
  • improved DRYness of the code
  • extended the Debug messages on the Serial Port
    Noted Problems:
  • sometimes AnalogInputQuerries register as id:0 even though no such request was set in ReefPi
  • this indicates a possible problem with AsyncTCP communication
  • backlog from crashes indicate that AsyncTCP is "at fault" or not perfectly compatible
  • crash frequency seems to increase with active flowmeter interrupts
  • possibly due to a conflict wit AsyncTCP, if that also uses interrupts for communication

Ignore Arduino secondary files

Update reef-pi.ino:
Improved DRYness
Extended Debug Messages
Included flowmeter compatibility
Included robo-tank pH compatibility
Included multiple DS18B20 sensors
Improved AnalogInput handling

Update reef-pi.ino

Improved DRYness
Extended Debug Messages
Included flowmeter compatibility
Included robo-tank pH compatibility
Included multiple DS18B20 sensors
Improved AnalogInput handling
This reverts commit 5d026ad.
Multiple flowmeters without volatile variable can be found in an earlier commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant