Merged
Conversation
redstrate
requested changes
Jan 6, 2026
Owner
redstrate
left a comment
redstrate
left a comment
There was a problem hiding this comment.
LGTM, I actually needed something like this for terrain shadow meshes too!
Co-authored-by: Joshua Goins <josh@redstrate.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a tag to a model part describing whether a mesh is actually a normal mesh or a water mesh. This does not need to happen for the other types of mesh because they have their own mesh list. Then I've extended the part converter to check all meshes instead of just looking at mesh meshes.
Now my renderer can find water meshes too :)
Fixes #28.