[v26.2.x] core: put c++23 range c-tor back in chunked_vector#294
Merged
WillemKauf merged 1 commit intoJun 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores a C++23 std::from_range constructor for seastar::chunked_vector, guarded by the standard library feature macro, and adds unit tests to validate construction from common ranges and move/copy element behavior.
Changes:
- Add
chunked_vector(std::from_range_t, Range&&)constructor (C++23, feature-gated) withsized_rangepre-reserve. - Add unit tests for
from_rangeconstruction from sized/unsized ranges and move-only element scenarios (feature-gated).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| include/seastar/core/chunked_vector.hh | Adds C++23 std::from_range constructor for chunked_vector. |
| tests/unit/chunked_vector_test.cc | Adds unit tests covering from_range construction and element move/copy semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+154
to
+163
| template <typename Range> | ||
| requires(std::ranges::range<Range>) | ||
| // NOLINTNEXTLINE(cppcoreguidelines-missing-std-forward) | ||
| chunked_vector(std::from_range_t, Range &&range) : chunked_vector() { | ||
| if constexpr (std::ranges::sized_range<Range>) { | ||
| reserve(std::ranges::size(range)); | ||
| } | ||
| std::copy(std::ranges::begin(range), std::ranges::end(range), | ||
| std::back_inserter(*this)); | ||
| } |
Comment on lines
+593
to
+598
| BOOST_AUTO_TEST_CASE(FromRangeUnsized) { | ||
| std::list<int32_t> input{1, 2, 3, 4, 5}; | ||
| auto vec = chunked_vector<int32_t>(std::from_range, input); | ||
| ASSERT_VALID(vec); | ||
| BOOST_REQUIRE(std::ranges::equal(vec, input)); | ||
| } |
Comment on lines
+611
to
+632
| BOOST_AUTO_TEST_CASE(FromRangeMove) { | ||
| static_assert( | ||
| !(std::is_copy_constructible_v<move_only_t> | ||
| || std::is_copy_assignable_v<move_only_t>)); | ||
|
|
||
| auto src = chunked_vector<move_only_t>(); | ||
| src.emplace_back(); | ||
| src.emplace_back(); | ||
|
|
||
| // From ref. | ||
| auto vec = chunked_vector<move_only_t>( | ||
| std::from_range, src | std::views::as_rvalue); | ||
| ASSERT_VALID(vec); | ||
| BOOST_REQUIRE_EQUAL(vec.size(), 2u); | ||
|
|
||
| // From temporary. | ||
| auto vec2 = chunked_vector<move_only_t>( | ||
| std::from_range, chunked_vector<move_only_t>() | std::views::as_rvalue); | ||
| ASSERT_VALID(vec2); | ||
| BOOST_REQUIRE(vec2.empty()); | ||
| } | ||
|
|
WillemKauf
changed the title
core: put c++23 range c-tor back in chunked_vectorcore: put c++23 range c-tor back in chunked_vector
StephanDollberg
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.