ct/l1/metastore: expose LSM probe metrics#31009
Open
andrwng wants to merge 1 commit into
Open
Conversation
The lsm::probe owned by each metastore_partition's replicated_database tracks a bunch of things already (hit rates, latencies, throttling, etc) but didn't register any Seastar metrics. This commit wraps them in a new probe that is labeled by metastore_partition.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Seastar metric exposure for the existing LSM lsm::probe used by each L1 metastore partition’s replicated_database, enabling per-metastore-partition observability of cache behavior, write throttling, and compaction/flush latencies.
Changes:
- Introduces
metastore_lsm_probe, a per-metastore-partition wrapper that registerslsm::probecounters/histograms as Seastar metrics. - Wires the new probe into
replicated_database::open()vialsm::options.probeand stores it for lifetime management. - Eagerly deregisters the metric group during
replicated_database::close()to avoid registration conflicts across leadership churn.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/v/cloud_topics/level_one/metastore/lsm/replicated_db.h | Stores a per-DB metastore_lsm_probe alongside the LSM database instance. |
| src/v/cloud_topics/level_one/metastore/lsm/replicated_db.cc | Creates the probe before DB open, passes it into lsm::options, and deregisters metrics on close. |
| src/v/cloud_topics/level_one/metastore/lsm/metastore_lsm_probe.h | Declares the probe wrapper API and metric deregistration hook. |
| src/v/cloud_topics/level_one/metastore/lsm/metastore_lsm_probe.cc | Implements metric registration for key LSM counters and latencies with metastore_partition labeling. |
| src/v/cloud_topics/level_one/metastore/lsm/BUILD | Adds a new Bazel library target and links it into the replicated DB build. |
Collaborator
CI test resultstest results on build#86691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lsm::probe owned by each metastore_partition's replicated_database tracks a bunch of things already (hit rates, latencies, throttling, etc) but didn't register any Seastar metrics.
This commit wraps them in a new probe that is labeled by metastore_partition.
Backports Required
Release Notes