container: use ss::chunked_vector#30965
Merged
Merged
Conversation
Contributor
Author
|
Backporting for redpanda-data/seastar#288 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches Redpanda’s container::chunked_vector wrapper to directly use Seastar’s ss::chunked_vector, removes the local async helper header/tests, and updates the Seastar third-party dependency to a revision that provides the needed chunked-vector headers/async helpers.
Changes:
- Replace the in-repo
chunked_vectorimplementation withusing ss::chunked_vectorand adjust Bazel deps accordingly. - Remove
container/chunked_vector_async.hand its associated test/BUILD target; switch call sites to Seastar’schunked_vector_asynchelpers. - Bump Seastar revision and update the Bazel
seastar.BUILDsurface to expose chunked-vector related headers and new deps.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/v/iceberg/datatypes.cc | Adds missing vassert include for code that uses vassert. |
| src/v/container/tests/chunked_vector_async_test.cc | Removes async helper tests (file deleted). |
| src/v/container/tests/BUILD | Removes the deleted async btest target and its macro load. |
| src/v/container/chunked_vector.h | Replaces the custom implementation with an alias to ss::chunked_vector. |
| src/v/container/chunked_vector_async.h | Removes local async helpers (file deleted). |
| src/v/container/BUILD | Updates the chunked_vector Bazel target headers and deps for Seastar-based implementation. |
| src/v/compaction/key_offset_map.cc | Switches to Seastar’s chunked_vector_async helpers. |
| MODULE.bazel.lock | Updates lockfile digests for the Seastar revision bump. |
| bazel/thirdparty/seastar.BUILD | Exposes additional Seastar headers and adds new transitive deps required by Seastar. |
| bazel/repositories.bzl | Updates Seastar archive URL/sha/strip_prefix to the new revision. |
bef2e4e to
630802b
Compare
WillemKauf
commented
Jun 30, 2026
630802b to
75557e7
Compare
sjust-redpanda
previously approved these changes
Jun 30, 2026
Collaborator
Retry command for Build#86544please wait until all jobs are finished before running the slash command |
Collaborator
CI test resultstest results on build#86544
test results on build#86596
|
StephanDollberg
previously approved these changes
Jul 1, 2026
Move `redpanda`'s chunked containers into our `seastar` fork.
aa6f6c0
b586711 to
708a3a0
Compare
StephanDollberg
previously approved these changes
Jul 1, 2026
708a3a0 to
5b07851
Compare
StephanDollberg
approved these changes
Jul 1, 2026
Collaborator
|
/backport v26.1.x |
Collaborator
|
Failed to create a backport PR to v26.1.x branch. I tried: |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: redpanda-data/seastar#289
Fixes: https://redpandadata.atlassian.net/browse/CORE-16754, https://redpandadata.atlassian.net/browse/CORE-16433, https://redpandadata.atlassian.net/browse/CORE-14682, potentially many more
Backports Required
Release Notes