Skip to content

container: use ss::chunked_vector#30965

Merged
WillemKauf merged 3 commits into
redpanda-data:devfrom
WillemKauf:ss_chunked_vector
Jul 1, 2026
Merged

container: use ss::chunked_vector#30965
WillemKauf merged 3 commits into
redpanda-data:devfrom
WillemKauf:ss_chunked_vector

Conversation

@WillemKauf

@WillemKauf WillemKauf commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

See: redpanda-data/seastar#289

Fixes: https://redpandadata.atlassian.net/browse/CORE-16754, https://redpandadata.atlassian.net/browse/CORE-16433, https://redpandadata.atlassian.net/browse/CORE-14682, potentially many more

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v26.1.x
  • v25.3.x
  • v25.2.x

Release Notes

  • none

Copilot AI review requested due to automatic review settings June 30, 2026 17:45
@WillemKauf

Copy link
Copy Markdown
Contributor Author

Backporting for redpanda-data/seastar#288

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches Redpanda’s container::chunked_vector wrapper to directly use Seastar’s ss::chunked_vector, removes the local async helper header/tests, and updates the Seastar third-party dependency to a revision that provides the needed chunked-vector headers/async helpers.

Changes:

  • Replace the in-repo chunked_vector implementation with using ss::chunked_vector and adjust Bazel deps accordingly.
  • Remove container/chunked_vector_async.h and its associated test/BUILD target; switch call sites to Seastar’s chunked_vector_async helpers.
  • Bump Seastar revision and update the Bazel seastar.BUILD surface to expose chunked-vector related headers and new deps.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/v/iceberg/datatypes.cc Adds missing vassert include for code that uses vassert.
src/v/container/tests/chunked_vector_async_test.cc Removes async helper tests (file deleted).
src/v/container/tests/BUILD Removes the deleted async btest target and its macro load.
src/v/container/chunked_vector.h Replaces the custom implementation with an alias to ss::chunked_vector.
src/v/container/chunked_vector_async.h Removes local async helpers (file deleted).
src/v/container/BUILD Updates the chunked_vector Bazel target headers and deps for Seastar-based implementation.
src/v/compaction/key_offset_map.cc Switches to Seastar’s chunked_vector_async helpers.
MODULE.bazel.lock Updates lockfile digests for the Seastar revision bump.
bazel/thirdparty/seastar.BUILD Exposes additional Seastar headers and adds new transitive deps required by Seastar.
bazel/repositories.bzl Updates Seastar archive URL/sha/strip_prefix to the new revision.

Comment thread src/v/container/chunked_vector.h
Comment thread src/v/container/BUILD
@WillemKauf WillemKauf force-pushed the ss_chunked_vector branch 5 times, most recently from bef2e4e to 630802b Compare June 30, 2026 19:00
Comment thread src/v/cloud_topics/level_zero/pipeline/tests/event_filter_test.cc Outdated
sjust-redpanda
sjust-redpanda previously approved these changes Jun 30, 2026
@vbotbuildovich

vbotbuildovich commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Retry command for Build#86544

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/upgrade_test.py::UpgradeBackToBackTest.test_upgrade_with_all_workloads@{"single_upgrade":false}
tests/rptest/tests/random_node_operations_smoke_test.py::RedpandaNodeOperationsSmokeTest.test_node_ops_smoke_test@{"cloud_storage_type":1,"mixed_versions":false}

@vbotbuildovich

vbotbuildovich commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

CI test results

test results on build#86544
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) DataMigrationsApiTest test_migrated_topic_data_integrity {"params": {"cancellation": {"dir": "in", "stage": "executing"}, "include_groups": false, "transfer_leadership": false, "use_alias": false}} integration https://buildkite.com/redpanda/redpanda/builds/86544#019f1a74-38dc-4f31-90f4-d6fa8049779e 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0000, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1000, p1=0.3487, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DataMigrationsApiTest&test_method=test_migrated_topic_data_integrity
FLAKY(FAIL) RedpandaNodeOperationsSmokeTest test_node_ops_smoke_test {"cloud_storage_type": 1, "mixed_versions": false} integration https://buildkite.com/redpanda/redpanda/builds/86544#019f1a74-38dd-4a90-9c13-a9e5fbcbcf22 8/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0152, p0=0.0096, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=RedpandaNodeOperationsSmokeTest&test_method=test_node_ops_smoke_test
FLAKY(FAIL) UpgradeBackToBackTest test_upgrade_with_all_workloads {"single_upgrade": false} integration https://buildkite.com/redpanda/redpanda/builds/86544#019f1a77-5b83-4339-a2c5-f2ef9e53a6b7 8/11 Test FAILS after retries.Significant increase in flaky rate(baseline=0.0099, p0=0.0042, reject_threshold=0.0100) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=UpgradeBackToBackTest&test_method=test_upgrade_with_all_workloads
test results on build#86596
test_status test_class test_method test_arguments test_kind job_url passed reason test_history
FLAKY(PASS) ShadowLinkingReplicationTests test_auto_prefix_trimming {"source_cluster_spec": {"cluster_type": "redpanda"}, "storage_mode": "tiered", "with_failures": false} integration https://buildkite.com/redpanda/redpanda/builds/86596#019f1e03-b37e-43c7-bd12-c15fe52d62a2 10/11 Test PASSES after retries.No significant increase in flaky rate(baseline=0.0399, p0=1.0000, reject_threshold=0.0100. adj_baseline=0.1150, p1=0.2946, trust_threshold=0.5000) https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ShadowLinkingReplicationTests&test_method=test_auto_prefix_trimming

StephanDollberg
StephanDollberg previously approved these changes Jul 1, 2026

@StephanDollberg StephanDollberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to do the same for chunked_hashmap (or is that a separate PR)?

Move `redpanda`'s chunked containers into our `seastar` fork.
@WillemKauf WillemKauf dismissed stale reviews from StephanDollberg and sjust-redpanda via aa6f6c0 July 1, 2026 12:52
@WillemKauf WillemKauf force-pushed the ss_chunked_vector branch 3 times, most recently from b586711 to 708a3a0 Compare July 1, 2026 13:26
StephanDollberg
StephanDollberg previously approved these changes Jul 1, 2026
@WillemKauf WillemKauf enabled auto-merge July 1, 2026 15:08
@WillemKauf WillemKauf merged commit 1bd30c6 into redpanda-data:dev Jul 1, 2026
20 checks passed
@vbotbuildovich

Copy link
Copy Markdown
Collaborator

/backport v26.1.x

@vbotbuildovich

Copy link
Copy Markdown
Collaborator

Failed to create a backport PR to v26.1.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-30965-v26.1.x-924 remotes/upstream/v26.1.x
git cherry-pick -x cd2dd6b3aa 28e89cae64 5b07851af8

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants