This repository was archived by the owner on Jul 30, 2025. It is now read-only.
Add additional error handling for txn to increase stability#16
Open
ballard26 wants to merge 1 commit into
Open
Add additional error handling for txn to increase stability#16ballard26 wants to merge 1 commit into
ballard26 wants to merge 1 commit into
Conversation
ballard26
force-pushed
the
repeater-txn-error-handling
branch
from
965e389 to
18aca5e
Compare
ballard26
force-pushed
the
repeater-txn-error-handling
branch
from
18aca5e to
3eea505
Compare
6 tasks
Contributor
|
Can you add error counters in the producer status struct? I suspect there will be some transaction tests that expect no such errors, and some that will expect errors. As I understand it, the transaction code should cope gracefully with intentional node shutdowns (where leaderships are transferred away first), but is allowed to hit an error when nodes unexpectedly stop. So each test case should know which kind of restarts it is doing, and be tolerant or intolerant of errors accordingly. |
Contributor
Author
|
Yeah, I'll add an error counter. Will talk to Bharath about whether this behavior is always expected or not. If not I'll add flag to enable this new behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors such as
OperationNotAttemptedandInvalidTxnStatecan be pretty common while doing transactions on clusters whose nodes are being started and stopped randomly. This PR attempts to recover a producer from these errors.