Skip to content

azure: add blob index tags support for blob storage output#4204

Open
fredmeltwater wants to merge 2 commits into
redpanda-data:mainfrom
fredmeltwater:feat/azure-blob-storage-tags
Open

azure: add blob index tags support for blob storage output#4204
fredmeltwater wants to merge 2 commits into
redpanda-data:mainfrom
fredmeltwater:feat/azure-blob-storage-tags

Conversation

@fredmeltwater

@fredmeltwater fredmeltwater commented Apr 1, 2026

Copy link
Copy Markdown

Summary

  • Adds a new tags field to the azure_blob_storage output, allowing users to set blob index tags as key/value
    pairs with interpolation support
  • Tags are applied atomically on block blob uploads and via SetTags for append blobs
  • Enforces Azure's 10-tag limit at config parse time
  • review skill used on this PR

Closes #2904

Test plan

  • go build ./internal/impl/azure/... passes
  • go test ./internal/impl/azure/... -short passes
  • Integration test blob_storage_tags validates tags are set correctly on block blobs via Azurite

🤖 Generated with Claude Code

Closes redpanda-data#2904

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

@meltwater-coreplatform meltwater-coreplatform left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits

LGTM

Review

Clean implementation adding blob index tags support to the azure_blob_storage output. Tags are parsed at config time as an InterpolatedStringMap with a 10-tag limit (matching Azure's constraint), deterministically sorted, and resolved per-message. Block blobs pass tags via UploadStreamOptions; append blobs set tags at creation via CreateOptions and update them on subsequent appends via SetTags. Integration test validates tag roundtrip through Azurite.

LGTM

@CLAassistant

CLAassistant commented Apr 1, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@fredmeltwater

Copy link
Copy Markdown
Author

Hi @Jeffail this has been open for a few weeks — would love a review when you get a
chance

@josephwoodward

Copy link
Copy Markdown
Contributor

Hi @fredmeltwater, are you able to run task docs on this to generate the new docs?

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fredmeltwater

Copy link
Copy Markdown
Author

Hi @josephwoodward were you able to take a look?

@VictorErmakov

Copy link
Copy Markdown

Just a bump for this PR. We are really looking into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Metadata and Tags support for azure_blob_storage

5 participants