azure: add blob index tags support for blob storage output#4204
azure: add blob index tags support for blob storage output#4204fredmeltwater wants to merge 2 commits into
Conversation
Closes redpanda-data#2904 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
meltwater-coreplatform
left a comment
There was a problem hiding this comment.
Commits
LGTM
Review
Clean implementation adding blob index tags support to the azure_blob_storage output. Tags are parsed at config time as an InterpolatedStringMap with a 10-tag limit (matching Azure's constraint), deterministically sorted, and resolved per-message. Block blobs pass tags via UploadStreamOptions; append blobs set tags at creation via CreateOptions and update them on subsequent appends via SetTags. Integration test validates tag roundtrip through Azurite.
LGTM
|
Hi @Jeffail this has been open for a few weeks — would love a review when you get a |
|
Hi @fredmeltwater, are you able to run |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hi @josephwoodward were you able to take a look? |
|
Just a bump for this PR. We are really looking into it |
Summary
tagsfield to theazure_blob_storageoutput, allowing users to set blob index tags as key/valuepairs with interpolation support
SetTagsfor append blobsreviewskill used on this PRCloses #2904
Test plan
go build ./internal/impl/azure/...passesgo test ./internal/impl/azure/... -shortpassesblob_storage_tagsvalidates tags are set correctly on block blobs via Azurite🤖 Generated with Claude Code