Acknowledgment of Configuration Updates in Watcher Mode. #91#95
Open
Tirth7545 wants to merge 3 commits intoredpanda-data:mainfrom
Open
Acknowledgment of Configuration Updates in Watcher Mode. #91#95Tirth7545 wants to merge 3 commits intoredpanda-data:mainfrom
Tirth7545 wants to merge 3 commits intoredpanda-data:mainfrom
Conversation
|
|
Author
|
Hi, @mihaitodor could you please review this ? |
Jeffail
requested changes
Sep 26, 2024
internal/api/api.go
Outdated
| wholeConf any, | ||
| log log.Modular, | ||
| stats metrics.Type, | ||
| count *int, |
Collaborator
There was a problem hiding this comment.
Rather than slowly adding more parameters here it might be worth replacing wholeConf with an abstraction that allows these other peices of information to be accessed, which we can expand over time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desciption
Acceptance Criteria
API Reference
Get Succss reload count
GET /benthos/config/ackResponse Body
success_reload_countstringGithub Issue : #91