fix(docs): commit missing redis-logo-script-red.svg to unblock Pages build#32
Merged
Conversation
The hero block on the docs landing page (added in #31) references `assets/redis-logo-script-red.svg` (the cursive Redis wordmark in the official red #FF4438), but the file itself was never committed. The GitHub Pages build runs with `mkdocs build --strict`, which promotes the resulting warning into a hard failure: WARNING - Doc file 'index.md' contains a link 'assets/redis-logo-script-red.svg', but the target is not found among documentation files. Aborted with 1 warnings in strict mode! Add the missing asset alongside the existing white-fill variant (`redis-logo-script.svg`, used in the dark navbar). Verified locally: $ DISABLE_MKDOCS_2_WARNING=true uv run --group docs mkdocs build --strict INFO - Documentation built in ~3s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for the broken
Deploy docs to GitHub Pagesworkflow. The heroblock on the docs landing page references
assets/redis-logo-script-red.svg, but the SVG itself was nevercommitted.
mkdocs build --strict(used by.github/workflows/docs.yml)promotes the missing-target warning into a hard failure.
Failure (run 25694894190)
Fix
Add the missing asset. It is the cursive Redis wordmark in the official
red
#FF4438, the red-on-light counterpart of the existingredis-logo-script.svg(white, used in the dark navbar).Verification
Once merged, the next push to
maintriggers a fresh deploy andpublishes the landing page with the red wordmark hero.