Update for libary to support physical card testing#163
Merged
GeorgePantelakis merged 1 commit intoredhat-qe-security:masterfrom Mar 3, 2026
Merged
Conversation
Collaborator
Author
|
Important question. Should we update it to 3.5.0 or move it to 4.0.0 since it is a big change after all? |
Collaborator
Author
|
Note to self: add docstrings everywhere. |
GeorgePantelakis
force-pushed
the
removinator-support
branch
2 times, most recently
from
74c3349 to
eb6075b
Compare
Jakuje
reviewed
Jan 6, 2026
Comment on lines
-59
to
+64
| lambda l: 1 <= len(l.keys()) <= 2, # noqa: E741 | ||
| {Optional("local_ca"): { | ||
| Optional("dir", default=Path("/etc/SCAutolib/ca")): Use(Path)}, | ||
| lambda l: 1 <= len(l.keys()) <= 3, # noqa: E741 | ||
| { | ||
| Optional("local_ca"): { | ||
| Optional("dir", default=Path("/etc/SCAutolib/ca")): Use(Path) | ||
| }, |
Collaborator
There was a problem hiding this comment.
nit: Its kind of annoying to read through the changes trying to figure out what the change makes and then end up figuring its just reformat.
In other projects, we try to keep reformatting changes in separate commits (before the actual changes), which makes it easier to differentiate the actual behavior change and reformat. Likely for next time.
GeorgePantelakis
force-pushed
the
removinator-support
branch
2 times, most recently
from
744d56f to
8aadab2
Compare
Collaborator
Author
|
@Jakuje pushed a new version of the code! |
Jakuje
reviewed
Jan 7, 2026
GeorgePantelakis
force-pushed
the
removinator-support
branch
2 times, most recently
from
95e5c4f to
e6e32fd
Compare
Jakuje
approved these changes
Jan 12, 2026
GeorgePantelakis
force-pushed
the
removinator-support
branch
3 times, most recently
from
cac3797 to
3cd5bda
Compare
GeorgePantelakis
force-pushed
the
removinator-support
branch
from
3cd5bda to
9241f6a
Compare
GeorgePantelakis
force-pushed
the
removinator-support
branch
from
9241f6a to
639cca5
Compare
GeorgePantelakis
merged commit 615bd7e
into
redhat-qe-security:master
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.