Skip to content

updating operator-framework api w/ additional bundle validation#1370

Merged
acornett21 merged 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21:update_of_api
Mar 3, 2026
Merged

updating operator-framework api w/ additional bundle validation#1370
acornett21 merged 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21:update_of_api

Conversation

@acornett21
Copy link
Copy Markdown
Contributor

Motivation

Over time and historically, the catalogs produced by any/all of are tooling, contain bundles that:

  • break for all customers
  • break for some customers
  • break the OCP UI

With that we try to improve the validation overtime as more and more sharp edges are found. One such incident was found where a partners relatedImages section contained an invalid sha256 value, casing oc-mirror of the catalog to be broken. Luckly, for that instance, the bundle in question was the first version that the operator author had released, so a removal/fix was able to be made.

During that remove/fix operator-framework/api was updated with further bundle validation to catch these types of issues:

Testing

This PR points to a fork/commit of operator-framework/api, below is what would be outputted for an incorrect bundle in the catalog.

PFLT_INDEXIMAGE=registry.redhat.io/redhat/certified-operator-index:v4.20 preflight check operator check operator registry.connect.redhat.com/nvidia/gpu-operator-bundle:v23.3.0

...
time="2026-02-16T10:41:18-07:00" level=error msg="Error: Value spec.relatedImages[3].image: relatedImages[3] has an invalid image pullspec \"nvcr.io/nvidia/k8s/container-toolkit@sha256:489125ceae5864280e4d6a9ab52ab0f650b3179349a7298c4a204feb60b661a\": invalid checksum digest length" check=ValidateOperatorBundle error="validate operator bundle error"
time="2026-02-16T10:41:18-07:00" level=info msg="check completed" check=ValidateOperatorBundle result=FAILED

@acornett21 acornett21 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@openshift-ci openshift-ci Bot requested review from jomkz and komish February 16, 2026 20:31
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 16, 2026

Coverage Status

coverage: 84.053%. remained the same
when pulling 57e747e on acornett21:update_of_api
into 5aed1c7 on redhat-openshift-ecosystem:main.

@acornett21 acornett21 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@dcibot
Copy link
Copy Markdown

dcibot commented Feb 16, 2026

@dcibot
Copy link
Copy Markdown

dcibot commented Feb 17, 2026

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2026
@dcibot
Copy link
Copy Markdown

dcibot commented Feb 25, 2026

@acornett21 acornett21 added gemini-review and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 25, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## 📋 Review Summary

This Pull Request updates multiple dependencies, particularly bumping operator-framework/api to v0.40.0 and adding a replace directive for testing additional bundle validation. The changes to go.mod and go.sum appear correct for a draft or testing context, but introduce a supply chain issue if merged as-is.

🔍 General Feedback

  • Dependency Updates: The general dependency version bumps and indirect module additions in go.mod and go.sum look standard and align with expected Go module management practices.
  • Testing Context: As mentioned in the PR description, if this branch is primarily for testing the output against a specific fork, consider converting the PR to a Draft to clearly signal that it is not yet ready to be merged.

Comment thread go.mod Outdated
@bcrochet
Copy link
Copy Markdown
Contributor

/retest

@dcibot
Copy link
Copy Markdown

dcibot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit more here than just operator-framework api... I'm fine with that, as long as we've validated that things like graphql and go-containerregistry haven't had breaking changes.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2026
Signed-off-by: Adam D. Cornett <adc@redhat.com>
@acornett21
Copy link
Copy Markdown
Contributor Author

@bcrochet I thought I had added those as a separate commit, but since I did not I just rolled them back to keep this PR clean. I'll update the other things in another PR.

@dcibot
Copy link
Copy Markdown

dcibot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

@bcrochet bcrochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@acornett21 acornett21 merged commit 1a41e40 into redhat-openshift-ecosystem:main Mar 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants