updating operator-framework api w/ additional bundle validation#1370
Conversation
|
from change #1370: |
82b0a8b to
57e747e
Compare
|
from change #1370: |
57e747e to
3d34f66
Compare
|
from change #1370: |
There was a problem hiding this comment.
This Pull Request updates multiple dependencies, particularly bumping operator-framework/api to v0.40.0 and adding a replace directive for testing additional bundle validation. The changes to go.mod and go.sum appear correct for a draft or testing context, but introduce a supply chain issue if merged as-is.
🔍 General Feedback
- Dependency Updates: The general dependency version bumps and indirect module additions in
go.modandgo.sumlook standard and align with expected Go module management practices. - Testing Context: As mentioned in the PR description, if this branch is primarily for testing the output against a specific fork, consider converting the PR to a Draft to clearly signal that it is not yet ready to be merged.
|
/retest |
3d34f66 to
65e7bb9
Compare
|
from change #1370: |
bcrochet
left a comment
There was a problem hiding this comment.
There's a bit more here than just operator-framework api... I'm fine with that, as long as we've validated that things like graphql and go-containerregistry haven't had breaking changes.
/lgtm
65e7bb9 to
725ff0a
Compare
Signed-off-by: Adam D. Cornett <adc@redhat.com>
725ff0a to
a2415ff
Compare
|
@bcrochet I thought I had added those as a separate commit, but since I did not I just rolled them back to keep this PR clean. I'll update the other things in another PR. |
|
from change #1370: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acornett21, bcrochet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Motivation
Over time and historically, the catalogs produced by any/all of are tooling, contain bundles that:
With that we try to improve the validation overtime as more and more sharp edges are found. One such incident was found where a partners
relatedImagessection contained an invalidsha256value, casingoc-mirrorof the catalog to be broken. Luckly, for that instance, the bundle in question was the first version that the operator author had released, so aremoval/fixwas able to be made.During that
remove/fixoperator-framework/api was updated with further bundle validation to catch these types of issues:Testing
This PR points to a fork/commit of
operator-framework/api, below is what would be outputted for an incorrect bundle in the catalog.