WIP TinMan.py: adjust to oz generate_diskimage size unit changing#458
Open
AdamWill wants to merge 1 commit intoredhat-imaging:masterfrom
Open
WIP TinMan.py: adjust to oz generate_diskimage size unit changing#458AdamWill wants to merge 1 commit intoredhat-imaging:masterfrom
AdamWill wants to merge 1 commit intoredhat-imaging:masterfrom
Conversation
In clalancette/oz#310 I'm proposing we change the unit of the `generate_diskimage` method's size arg from gibibytes to bytes. This needs adjusting to match that. Don't merge this unless and until that PR is merged. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In clalancette/oz#310 I'm proposing we change the unit of the
generate_diskimagemethod's size arg from gibibytes to bytes. This needs adjusting to match that. Don't merge this unless and until that PR is merged.