-
Notifications
You must be signed in to change notification settings - Fork 222
chore(install-dynamic-plugins): consume installer from npm via root yarn workspace #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
96ba7ea
82f7c0c
b36a8ca
a791195
78952d9
f8ce097
bfdfe8f
dd7b4b1
48157ec
e936008
2e704a2
dc18ca3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,7 @@ | |
| "@opentelemetry/instrumentation-runtime-node": "0.30.0", | ||
| "@opentelemetry/sdk-node": "0.218.0", | ||
| "@red-hat-developer-hub/backstage-plugin-translations-backend": "0.3.1", | ||
| "@red-hat-developer-hub/cli-module-install-dynamic-plugins": "0.2.0", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why in backend and not in root package.json? PR description actually says that this is in root pakages.json This is a build-time tool invoked in the If the only reason for moving it here was failing Could also be a nice opportunity to add a convenience script in root package.json:
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PR description updated. Sherif (monorepo:check) rejects dependencies on a private root, so moved it to
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gustavolira Sorry, I missed your comment. I've updated my comment before I noticed your reply 😇 tldr: that check can be configured to ignore some packages |
||
| "app": "workspace:*", | ||
| "app-next": "workspace:*", | ||
| "better-sqlite3": "12.6.2", | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why constructing shell script directly in Containerfile? This looks weird, why not keeping install-dynamic-plugins.sh as regular file in repo? Is there benefit of doing this in Containerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shim is only 2 lines and uses the same path validated by the install --help smoke test. Keeping it inline makes validation and shim creation atomic, so any upstream change fails the build immediately instead of breaking at pod startup. Happy to move it to a checked-in .sh if preferred.