Skip to content

fix(fab): remove fab plugin completely#4889

Closed
ciiay wants to merge 5 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin
Closed

fix(fab): remove fab plugin completely#4889
ciiay wants to merge 5 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin

Conversation

@ciiay

@ciiay ciiay commented May 26, 2026

Copy link
Copy Markdown
Member

Description

For RHIDP-13680

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from rm3l and teknaS47 May 26, 2026 18:09
@codecov

codecov Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.18%. Comparing base (fe578e0) to head (c18a10a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4889       +/-   ##
===========================================
- Coverage   55.82%   29.18%   -26.65%     
===========================================
  Files         121      120        -1     
  Lines        2350     2087      -263     
  Branches      562      563        +1     
===========================================
- Hits         1312      609      -703     
- Misses       1033     1472      +439     
- Partials        5        6        +1
Flag Coverage Δ
rhdh 29.18% <ø> (-26.65%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe578e0...c18a10a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented May 27, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@ciiay

ciiay commented May 27, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented May 28, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@ciiay

ciiay commented May 28, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@sanketpathak

sanketpathak commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The 1.10 tag might be causing the failure. CI still uses catalog-index 1.10, which was built before that removal

rhdh/.ci/pipelines/value_files/values_showcase.yaml

Lines 3 to 7 in 105732d

catalogIndex:
image:
registry: quay.io
repository: rhdh/plugin-catalog-index
tag: "1.10"

its-mitesh-kumar
its-mitesh-kumar reviewed Jun 1, 2026
View reviewed changes

@its-mitesh-kumar its-mitesh-kumar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

teknaS47
teknaS47 approved these changes Jun 3, 2026
View reviewed changes

@teknaS47 teknaS47 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin branch from cf67943 to af22fb2 Compare June 3, 2026 21:14
@openshift-ci openshift-ci Bot removed the lgtm label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin branch from af22fb2 to e36c2f4 Compare June 4, 2026 15:00
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

ciiay added 2 commits June 10, 2026 13:56
@ciiay
fix(fab): remove fab plugin completely
8cae1d5 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
disable fab tests on ci
947befa 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin branch from e36c2f4 to 947befa Compare June 10, 2026 17:56
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

@ciiay
resolve building failure
f82035d 
Signed-off-by: Yi Cai <yicai@redhat.com>
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

@ciiay
fix build failure
2f56ef3 
Signed-off-by: Yi Cai <yicai@redhat.com>
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: failure.

@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

@ciiay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 2f56ef3 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

debsmita1
debsmita1 suggested changes Jun 11, 2026
View reviewed changes

@debsmita1 debsmita1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still see some fab references in the locale json files

Comment thread .ci/pipelines/value_files/values_showcase.yaml
Comment on lines +21 to +22
- package: ./dynamic-plugins/dist/red-hat-developer-hub-backstage-plugin-global-floating-action-button
disabled: true

@debsmita1 debsmita1 Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed if we are removing fab ?

@ciiay ciiay Jun 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with Sanket, we still need this to pass the current CI. Once this pr gets merged and new index gets released I have a follow up task to clean up this.

@ciiay
removed fab localization
c18a10a 
Signed-off-by: Yi Cai <yicai@redhat.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ciiay

ciiay commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Closing this pr in favor of #4920

@ciiay ciiay closed this Jun 12, 2026
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rm3l rm3l Awaiting requested review from rm3l

3 more reviewers

@its-mitesh-kumar its-mitesh-kumar its-mitesh-kumar left review comments

@debsmita1 debsmita1 debsmita1 requested changes

@teknaS47 teknaS47 teknaS47 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@debsmita1 debsmita1

@teknaS47 teknaS47

@its-mitesh-kumar its-mitesh-kumar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ciiay @sanketpathak @debsmita1 @teknaS47 @its-mitesh-kumar