chore(backstage): bump test utils and remove auth-api-hack#2027
Closed
PatAKnight wants to merge 1 commit intoredhat-developer:mainfrom
Closed
chore(backstage): bump test utils and remove auth-api-hack#2027PatAKnight wants to merge 1 commit intoredhat-developer:mainfrom
PatAKnight wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Patrick Knight <pknight@redhat.com>
Member
Author
|
/publish |
|
Member
Author
|
Waiting for publish and the e2e tests to complete before I fix the |
Contributor
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
Contributor
|
|
Member
|
@PatAKnight I have removed api hack within the Kubernetes PR because Subhash asked me to update utils version there and I needed to do changes in the events spec file to fix prettier and tsc check anyway. I can remove those commits if you would like to rather merge this separate PR. |
Member
Author
|
@dzemanov, we can close this one in favor of yours |
❌ Failed E2E Tests -
|
|
@PatAKnight: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from this PR where we are now exposing the
RhdhAuthApiHackas theAuthApiHelperfrom rhdh-e2e-test-utils. This PR removes the no longer neededRhdhAuthApiHackand bumps rhdh-e2e-test-utils.