docs: add fullsend deployment documentation#4
Merged
Conversation
Extracts operational knowledge from the private lab notebook into reference docs, making rhdh-fullsend the canonical home for RHDH fullsend documentation. Secrets and internal URLs are sanitized. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a set of deployment/reference documents to this repo and updates existing docs/README to make fullsend onboarding, GCP/WIF setup, sandbox networking behavior, and known issues discoverable for RHDH consumers.
Changes:
- Add four new reference docs: repo onboarding, GCP infrastructure, sandbox networking, and known issues.
- Update
README.mdto include a documentation index and simplify the “Local agent runs” pointer. - Deduplicate service-account creation steps in
docs/local-setup.mdby linking to the new GCP infrastructure reference.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds a docs index table and streamlines local agent run guidance. |
| images/code/Containerfile | Updates header comments to describe Yarn availability and proxy/DNS notes. |
| docs/local-setup.md | Replaces repeated SA-creation commands with a link to the new GCP reference doc. |
| docs/repo-onboarding.md | New guide covering standard vs manual fullsend install, WIF, secrets/vars, and repo hardening tips. |
| docs/gcp-infrastructure.md | New reference for the RHDH GCP project, WIF provider creation, IAM, and SA/key workflows. |
| docs/sandbox-networking.md | New deep-dive on nested netns DNS failure and proxy-based workarounds with upstream issue links. |
| docs/known-issues.md | New consolidated list of current friction points, workarounds, and upstream tracking. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+11
| # Yarn is available on PATH immediately — no runtime corepack setup needed. | ||
| # DNS proxy config is handled by env/yarn-proxy.env (maps OpenShell's | ||
| # HTTP_PROXY to YARN_HTTP_PROXY). |
Comment on lines
+78
to
+79
| gh variable set FULLSEND_GCP_REGION --repo <org>/<repo> \ | ||
| --body "global" |
Comment on lines
+80
to
+83
| gh secret set FULLSEND_GCP_WIF_PROVIDER --repo <org>/<repo> \ | ||
| --body "<wif-provider-path>" | ||
| gh secret set FULLSEND_GCP_PROJECT_ID --repo <org>/<repo> \ | ||
| --body "rhdh-sidekick-167988" |
Comment on lines
+60
to
+62
| | `curl https://...` | ✅ | Intercepted by transparent proxy | | ||
| | `node -e "fetch('https://...')"` | ✅ | Node's fetch connects to IP; proxy intercepts TCP | | ||
| | `gh api ...` | ✅ | Uses HTTPS | |
| | `nslookup`, `dig` | ❌ | Direct DNS queries | | ||
| | `dns.resolve()` (Node.js) | ❌ | Direct DNS queries | | ||
|
|
||
| ## Workaround: explicit proxy in .yarnrc.yml |
Comment on lines
+110
to
+114
| CI (GitHub Actions) uses the same stack — Podman + OpenShell + same | ||
| `action.yml`. The inner netns is identical. `yarn install` works in CI | ||
| because Node.js's `undici` (used by yarn's fetch) handles connections in a | ||
| way that gets intercepted by the transparent proxy before DNS resolution | ||
| is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asdlc-lab/mice/fullsend-ai/observations/):gh secret setcommandsTest plan
grep -rn 'redhat-internal.slack.com' docs/returns nothinggrep -rn 'UR0163679' docs/returns nothinggrep -rn 'gh secret set.*--body' docs/returns nothinggcloudcommands for accuracy against liverhdh-sidekick-167988project🤖 Generated with Claude Code