feat: prevent premature namespace teardown and redundant re-deployments on worker restarts #47
Merged
jrichter1 merged 4 commits intoredhat-developer:mainfrom Mar 6, 2026
Conversation
jrichter1
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHIDP-12518
What
Moves namespace cleanup from the worker fixture's finally block to a custom Playwright reporter, and adds built-in protection against redundant deploy() calls when workers restart after test
failures.
Why
When a test fails, Playwright kills the worker and creates a new one for remaining tests. This caused:
How
Consumer impact
No changes needed for the default configure() + deploy() pattern — works out of the box. For pre-deploy setup, wrap in test.runOnce():
// Simple — no changes needed
test.beforeAll(async ({ rhdh }) => {
await rhdh.configure({ auth: "keycloak" });
await rhdh.deploy();
});
// Pre-deploy setup — wrap in test.runOnce
test.beforeAll(async ({ rhdh }) => {
await test.runOnce("tech-radar-setup", async () => {
await rhdh.configure({ auth: "keycloak" });
await $
bash deploy-service.sh ${rhdh.deploymentConfig.namespace};await rhdh.deploy();
});
});