-
Notifications
You must be signed in to change notification settings - Fork 6
Final Steps To Archive Repository #23
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdubrick Should remove all references to weekly schedule on Wednesdays as well.
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdubrick These lines should also be revised to remove the Wednesday schedule from them.
Nit suggestion: I notice the .ci/build.sh fails when I run it, though it is not required I feel it would be great to pin the registry-support reference, such as devfile/registry-support@4bc237b, so if it does work on a previous state someone can still build the image. I would say only do this if its an easy change otherwise I won't block this PR due to this.
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
I updated the readme and pinned the commit, I had to force the checkout but the collisions were in vendor file readme files so I think it's alright. If we don't want to do that I can revert it, fyi @michael-valdron |
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build seems to work now 😄
Just the one comment I have left and should be good to merge.
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
michael-valdron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR performs the following steps in preparation for archiving this repository:
resolves devfile/api#1682