OCPBUGS-69698: Fix T-BC holdover to locked event not firing by nocturnalastro · Pull Request #619 · redhat-cne/cloud-event-proxy

nocturnalastro · 2025-12-17T20:14:43Z

Holdover -> Locked event was not firing because ptp4l was setting the same state as T-BC. ptp4l moves to locked before T-BC. Because it updates more rapidly than T-BC. It will win the race. Meaning that when T-BC moves to locked the state is already considered locked meaning the event will not fire.

openshift-ci-robot · 2025-12-17T20:15:47Z

@nocturnalastro: This pull request references Jira Issue OCPBUGS-66133, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Holdover -> Locked event was not firing because ptp4l was setting the same state as T-BC. ptp4l moves to locked before T-BC. Because it updates more rapidly than T-BC. It will win the race. Meaning that when T-BC moves to locked the state is already considered locked meaning the event will not fire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Holdover -> Locked event was not firing because ptp4l was setting the same state as T-BC. ptp4l moves to locked before T-BC. Because it updates more rapidly than T-BC. It will win the race. Meaning that when T-BC moves to locked the state is already considered locked meaning the event will not fire.

openshift-ci-robot · 2025-12-17T20:42:58Z

@nocturnalastro: This pull request references Jira Issue OCPBUGS-69698, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dpopsuev

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Holdover -> Locked event was not firing because ptp4l was setting the same state as T-BC. ptp4l moves to locked before T-BC. Because it updates more rapidly than T-BC. It will win the race. Meaning that when T-BC moves to locked the state is already considered locked meaning the event will not fire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-12-17T20:43:01Z

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: dpopsuev.

Note that only redhat-cne members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@nocturnalastro: This pull request references Jira Issue OCPBUGS-69698, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)

bug target version (4.22.0) matches configured target version for branch (4.22.0)

bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dpopsuev

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Holdover -> Locked event was not firing because ptp4l was setting the same state as T-BC. ptp4l moves to locked before T-BC. Because it updates more rapidly than T-BC. It will win the race. Meaning that when T-BC moves to locked the state is already considered locked meaning the event will not fire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vitus133

There is a couple of nits related to the old comments, could it be possible to jump on the opportunity and fix them?
If not - no problem

vitus133 · 2025-12-17T21:57:32Z

-	ptpStats[masterType].SetPtpDependentEventState(clockState, ptpStats.HasMetrics(processName), ptpStats.HasMetricHelp(processName))
+	ptpStats[tbcClockNameType].SetPtpDependentEventState(clockState, ptpStats.HasMetrics(processName), ptpStats.HasMetricHelp(processName))

 	// If GM is locked/Freerun/Holdover then ptp state change event


nit - remove or fix this useless comment

vitus133 · 2025-12-17T22:00:36Z

 	T-BC 1689014436   ts2phc.1.config ens7f0  offset  123 T-BC-STATUS s1
 	HOLDOVER
 	0       1              2     	   3       4         5         6           7          8
 	T-BC 1689014436  ts2phc.1.config ens7f0  offset      123    T-BC-STATUS   s3      holdover


nit: This seems to be wrong ATM - never send "holdover" or something like that. Holdover is "s1".

openshift-ci · 2025-12-17T22:04:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nocturnalastro, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [nocturnalastro,vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vitus133 · 2025-12-17T22:06:54Z

/retest-required

openshift-ci-robot · 2025-12-17T23:30:26Z

@nocturnalastro: Jira Issue OCPBUGS-69698: All pull requests linked via external trackers have merged:

redhat-cne/cloud-event-proxy#619

Jira Issue OCPBUGS-69698 has been moved to the MODIFIED state.

Details

In response to this:

Holdover -> Locked event was not firing because ptp4l was setting the same state as T-BC. ptp4l moves to locked before T-BC. Because it updates more rapidly than T-BC. It will win the race. Meaning that when T-BC moves to locked the state is already considered locked meaning the event will not fire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

nocturnalastro · 2025-12-18T15:12:07Z

/jira cherry-pick release-4.21

nocturnalastro · 2025-12-18T15:12:43Z

/jira cherrypick release-4.21

nocturnalastro · 2026-01-06T10:40:41Z

/cherrypick release-4.21

openshift-cherrypick-robot · 2026-01-06T10:41:25Z

@nocturnalastro: new pull request created: #621

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot requested review from aneeshkp and rdavid December 17, 2025 20:14

openshift-ci Bot added the approved label Dec 17, 2025

nocturnalastro changed the title ~~Fix T-BC holdover to locked event not firing~~ OCPBUGS-66133: Fix T-BC holdover to locked event not firing Dec 17, 2025

openshift-ci-robot added jira/severity-critical jira/valid-reference jira/invalid-bug labels Dec 17, 2025

nocturnalastro force-pushed the fix_tbc_holdover branch from 370b051 to 3116fd9 Compare December 17, 2025 20:24

nocturnalastro force-pushed the fix_tbc_holdover branch from 3116fd9 to b72d62e Compare December 17, 2025 20:37

nocturnalastro added the ok-to-test label Dec 17, 2025

nocturnalastro changed the title ~~OCPBUGS-66133: Fix T-BC holdover to locked event not firing~~ OCPBUGS-69698: Fix T-BC holdover to locked event not firing Dec 17, 2025

openshift-ci-robot added jira/valid-bug and removed jira/invalid-bug labels Dec 17, 2025

vitus133 approved these changes Dec 17, 2025

View reviewed changes

openshift-ci Bot assigned vitus133 Dec 17, 2025

openshift-ci Bot added the lgtm label Dec 17, 2025

openshift-merge-bot Bot merged commit 32bb03b into redhat-cne:main Dec 17, 2025
8 of 10 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 6, 2026

[release-4.21] OCPBUGS-69997: Fix T-BC holdover to locked event not firing #621

Merged

Conversation

nocturnalastro commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

openshift-ci Bot commented Dec 17, 2025

Uh oh!

vitus133 left a comment

Choose a reason for hiding this comment

Uh oh!

vitus133 Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

vitus133 Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Dec 17, 2025

Uh oh!

vitus133 commented Dec 17, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 17, 2025

Uh oh!

nocturnalastro commented Dec 18, 2025

Uh oh!

nocturnalastro commented Dec 18, 2025

Uh oh!

nocturnalastro commented Jan 6, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants