[RHIDP-12668] Update Library Image to Sprint 3289 Version#42
[RHIDP-12668] Update Library Image to Sprint 3289 Version#42Jdubrick merged 9 commits intoredhat-ai-dev:devfrom
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
|
@Jdubrick why dont we promote the configs repo and just phase this repo out? |
@maysunfaisal @michael-valdron is onboarding the library side of the build to Konflux as a fallback plan for 1.10, incase we need it. There's been discussion about LCORE providing a library mode image however. I think we keep it relatively updated for now but am totally good with phasing this repo out and archiving it if:
wdyt? |
env/default-values.env
Outdated
| LIGHTSPEED_CORE_IMAGE=quay.io/lightspeed-core/lightspeed-stack:dev-20260316-b2f54cf | ||
| LLAMA_STACK_IMAGE=quay.io/opendatahub/llama-stack:07a97331b3a8831e76ec15c833d2dcf6fa0a34c9 | ||
| RAG_CONTENT_IMAGE=quay.io/redhat-ai-dev/rag-content:release-1.9-lls-0.4.3 | ||
| OLLAMA_IMAGE=docker.io/ollama/ollama:latest |
There was a problem hiding this comment.
@Jdubrick Would it make sense to pin these images? Considering renovate patching and release build consistency.
There was a problem hiding this comment.
that would be consistent with what we see here for the lightspeed/lls/rag images ... +1
There was a problem hiding this comment.
To be honest, the env vars you listed here aren't really used in this repo, they're just a side effect of the sync for getting the envs for enabling inference/safety etc from redhat-ai-dev/lightspeed-configs.
I will open a PR to lightspeed-configs repo to pin the RAG_CONTENT_IMAGE and OLLAMA_IMAGE to a sha instead of a tag that could move, does that work? I'll then add a commit to this PR to pull those changes
There was a problem hiding this comment.
First PR: redhat-ai-dev/lightspeed-configs#8
There was a problem hiding this comment.
Pulled changes in via this commit: a5828d0
There was a problem hiding this comment.
Also, if we want to move to digests, I'm all for that. I would handle it in a different issue though
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
What does this PR do?:
0.5.2present in the Lightspeed Core imageWhich issue(s) this PR fixes:
https://redhat.atlassian.net/browse/RHIDP-12668
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: