Patch: Address Failing Check and Add Config.env Check#25
Merged
Jdubrick merged 3 commits intoredhat-ai-dev:mainfrom Jan 8, 2025
Merged
Patch: Address Failing Check and Add Config.env Check#25Jdubrick merged 3 commits intoredhat-ai-dev:mainfrom
Jdubrick merged 3 commits intoredhat-ai-dev:mainfrom
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Jdubrick
changed the title
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Jdubrick
changed the title
thepetk
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR addresses 2 things:
models/detr-resnet-101directory was erroring out, there was trailing whitespace in the name and with the gh actions we're using it didn't like itMODEL_URLargument used as we are building from the image directoryconfig.envfile with metadata used for pushing to quayWhich issue(s) this PR fixes:
N/A, from a conversation here: #22 (comment)
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer:
If we decide we don't want the
config.envcheck that is okay and we can just commit the whitespace fix to enable checks to not fail in the future.