Skip to content

ECOPROJECT-4198 | feat: increase worker node max mem and cpu #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amalimov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ECOPROJECT-4198 | feat: increase worker node max mem and cpu #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 117 additions & 0 deletions lib/__tests__/ClusterSizer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,4 +363,121 @@ describe('ClusterSizer', () => {
expect(result.nodeCount).toBeGreaterThan(0);
});
});

describe('Large node sizes', () => {
// These tests verify cap behaviour in error messages (see MAX_SUGGESTED_CPU_CORES / MAX_SUGGESTED_MEMORY_GB
// in ClusterSizer.ts). They complement the existing 'should throw error for unschedulable workload'
// tests, which only assert that an error is thrown — not what the message says.

it('should successfully schedule a workload on a 300-CPU / 3000-GB node', () => {
const workloads: WorkloadDescriptor[] = [
{
name: 'large-workload',
count: 1,
usesMachines: [],
services: [
{
name: 'large-service',
requiredCPU: 250,
requiredMemory: 1800,
zones: 1,
runsWith: [],
avoid: []
}
]
}
];

const machineSets: MachineSet[] = [
{
name: 'worker',
cpu: 300,
memory: 3000,
instanceName: 'giant-node',
numberOfDisks: 24,
onlyFor: [],
label: 'Worker'
}
];

const result = ClusterSizer.size(workloads, Platform.BAREMETAL, machineSets);
expect(result.nodeCount).toBeGreaterThanOrEqual(1);
expect(result.totalCPU).toBeGreaterThanOrEqual(250); // at least enough for the service's requiredCPU
expect(result.totalMemory).toBeGreaterThanOrEqual(1800); // at least enough for the service's requiredMemory
});

it('should cap the CPU suggestion at 384 in the unschedulable error message', () => {
const workloads: WorkloadDescriptor[] = [
{
name: 'impossible-workload',
count: 1,
usesMachines: ['worker'],
services: [
{
name: 'huge-service',
requiredCPU: 500,
requiredMemory: 10,
zones: 1,
runsWith: [],
avoid: []
}
]
}
];

const machineSets: MachineSet[] = [
{
name: 'worker',
cpu: 32,
memory: 64,
instanceName: 'small-node',
numberOfDisks: 24,
onlyFor: [],
label: 'Worker'
}
];

// MAX_SUGGESTED_CPU_CORES = 384, defined in ClusterSizer.ts
expect(() => {
ClusterSizer.size(workloads, Platform.BAREMETAL, machineSets);
}).toThrow(/at least 384 CPU and \d+ GB/);
});

it('should cap the memory suggestion at 4096 in the unschedulable error message', () => {
const workloads: WorkloadDescriptor[] = [
{
name: 'impossible-workload',
count: 1,
usesMachines: ['worker'],
services: [
{
name: 'huge-service',
requiredCPU: 10,
requiredMemory: 5000,
zones: 1,
runsWith: [],
avoid: []
}
]
}
];

const machineSets: MachineSet[] = [
{
name: 'worker',
cpu: 32,
memory: 64,
instanceName: 'small-node',
numberOfDisks: 24,
onlyFor: [],
label: 'Worker'
}
];

// MAX_SUGGESTED_MEMORY_GB = 4096, defined in ClusterSizer.ts
expect(() => {
ClusterSizer.size(workloads, Platform.BAREMETAL, machineSets);
}).toThrow(/at least \d+ CPU and 4096 GB/);
});
});
});
11 changes: 7 additions & 4 deletions lib/src/core/ClusterSizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ export type ClusterSizing = {
services?: Service[];
};

const MAX_SUGGESTED_CPU_CORES = 384;
const MAX_SUGGESTED_MEMORY_GB = 4096;

export class ClusterSizer {
/**
* Main sizing function
Expand Down Expand Up @@ -137,10 +140,10 @@ export class ClusterSizer {
const machineSetMemory = targetMachineSet?.memory || 0;

// Calculate minimum required machineset size
// Round CPU up to nearest multiple of 2 (max 200)
// Round Memory up to nearest multiple of 4 (max 512)
const minRequiredCPU = Math.min(200, Math.ceil(totalRequiredCPU / 2) * 2);
const minRequiredMemory = Math.min(512, Math.ceil(totalRequiredMemory / 4) * 4);
// Round CPU up to nearest multiple of 2 (max MAX_SUGGESTED_CPU_CORES)
// Round Memory up to nearest multiple of 4 (max MAX_SUGGESTED_MEMORY_GB)
const minRequiredCPU = Math.min(MAX_SUGGESTED_CPU_CORES, Math.ceil(totalRequiredCPU / 2) * 2);
const minRequiredMemory = Math.min(MAX_SUGGESTED_MEMORY_GB, Math.ceil(totalRequiredMemory / 4) * 4);

throw new Error(
`Workload "${workload.name}" is not schedulable. ` +
Expand Down