Skip to content

Conversation

@samsonasik
Copy link
Member

@TomasVotruba this is continue of PR:

since leaveNode() method removed on AbstractRector, I think the leaveNode() calls can be removed from AbstractImmutableNodeTraverser

@samsonasik
Copy link
Member Author

@TomasVotruba ready 👍

@TomasVotruba
Copy link
Member

Seems good to me. The leaveNode() in AbstractRector should be marked as final to avoid override. Not just docblock, but natively.
Just in case someone would try to use it, so it's not skipped silent.y

@samsonasik
Copy link
Member Author

The leaveNode already removed from AbstractRector, do you mean I need to add leaveNode method back to AbstractRector ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants