-
-
Notifications
You must be signed in to change notification settings - Fork 424
feature: remove @return void from magic methods #7678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature: remove @return void from magic methods #7678
Conversation
|
The rule purpose is only remove For removing |
|
Can you help me a little then where / how it should be done? This is my forst contributing attempt |
|
|
Add another rule under rules/DeadCode/Rector/ClasaMethod, add test under rules-tests/DeadCode/Rector/ClassMethod as well |
|
@parijke Any update on this? I'd like to merge and ship it |
|
I'll be back Saturday from the holidays. I will do it in the upcoming week |
I think it should be in the Deadcode/PhpDoc namespace anyway? |
|
No need, just new rule under DeadCode\Recror\ClassMethod is fine imo :) |
29d7ee1 to
010b7b5
Compare
010b7b5 to
4b9d483
Compare
| @@ -0,0 +1,16 @@ | |||
| <?php | |||
|
|
|||
| namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUselessReturnTagRector\Fixture; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the fixture under new namespace directory RemoveUselessVoidReturnFromDocblockVoidMagicMethodsRector
This PR removed the dead code from magic methods.