Skip to content

[Rectify] [Php81] Enable Rectify for finalize public class constant only #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomasVotruba merged 6 commits into from
Dec 4, 2021
Merged

[Rectify] [Php81] Enable Rectify for finalize public class constant only #1380

TomasVotruba merged 6 commits into from
Dec 4, 2021

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Dec 4, 2021

split of #1364 by enable FinalizePublicClassConstantRector only.

@samsonasik samsonasik force-pushed the enable-finalize-public-class-constant branch from ce06457 to 7d42b56 Compare December 4, 2021 08:23
@samsonasik
Copy link
Member Author

samsonasik commented Dec 4, 2021

I temporary skip ArraySpreadInsteadOfArrayMergeRector::class as it make change for string key array unpack on php 8.1 which unrelated with this PR.

@samsonasik
Copy link
Member Author

samsonasik commented Dec 4, 2021

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik force-pushed the enable-finalize-public-class-constant branch from d3cb3f6 to 1bb4d50 Compare December 4, 2021 12:57
@samsonasik
Copy link
Member Author

samsonasik commented Dec 4, 2021

rebased.

@samsonasik samsonasik force-pushed the enable-finalize-public-class-constant branch from d65f3ce to a40013f Compare December 4, 2021 13:13
@samsonasik
Copy link
Member Author

samsonasik commented Dec 4, 2021

rebased.

@TomasVotruba TomasVotruba enabled auto-merge (squash) December 4, 2021 14:59
@TomasVotruba
Copy link
Member

TomasVotruba commented Dec 4, 2021

Thank you, needs to rebase but feel free to merge 👍

@TomasVotruba TomasVotruba merged commit eea8393 into main Dec 4, 2021
@TomasVotruba TomasVotruba deleted the enable-finalize-public-class-constant branch December 4, 2021 15:35
@samsonasik
Copy link
Member Author

samsonasik commented Dec 4, 2021

DowngradeFinalizePublicClassConstantRector somehow seems not applied on downgrade on build scoped process, I will check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samsonasik @TomasVotruba @actions-user