[CodeQuality] Skip with if on YieldDataProviderRector with yield from and return#557
Merged
samsonasik merged 10 commits intorectorphp:mainfrom Oct 19, 2025
Merged
[CodeQuality] Skip with if on YieldDataProviderRector with yield from and return#557samsonasik merged 10 commits intorectorphp:mainfrom
samsonasik merged 10 commits intorectorphp:mainfrom
Conversation
staabm
changed the title
Contributor
Author
|
@samsonasik please see another case of the same problem as in #556 |
samsonasik
reviewed
Oct 19, 2025
samsonasik
reviewed
Oct 19, 2025
Comment on lines
+16
to
+20
| yield from [ | ||
| ['value3', 'value4'], | ||
| ['value5', 'value6'], | ||
| ['value7', 'value8'], | ||
| ]; |
Member
There was a problem hiding this comment.
could you add test to allow multiple yield from ? see https://3v4l.org/seVoc
Contributor
Author
There was a problem hiding this comment.
I can add it, but the current rector impl will not work with it ;)
Contributor
Author
There was a problem hiding this comment.
or should I add a test, that this scenario will be skipped?
Member
There was a problem hiding this comment.
Yeah, I think we can fix with if yield form is multiple, just skip. findInstanceof() and count() > 1 should works.
samsonasik
approved these changes
Oct 19, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Looks good, let's give it a try 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.