Conversation
…ser's UID and GID
…ker cli's PID making request
…rs/create requests
reboss
force-pushed
the
user-cgroup-adoption
branch
from
4fa55ef to
bb15eea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add a "connection context" to the http server initialization. With this context, whenever a connection is made, it reads the SO_PEERCRED of the user that wrote to the docker.sock file to get the user's PID (PID of the docker cli command). Then it reads /proc/$PID/cgroup to get their cgroup and parses it. It then adds the HostConfig option, CgroupParent, which is what the command line arg --cgroup-parent= would translate to. This forces the container to have the Slurm provided cgroup and ensures that a user can only see the GPUs that they requested, and thus cannot interfere with others work by accident.