RCORE-2212 Make apply-to-state tool handle all batch states properly#7938
RCORE-2212 Make apply-to-state tool handle all batch states properly#7938
Conversation
Pull Request Test Coverage Report for Build jonathan.reams_3390Details
💛 - Coveralls |
michael-wb
left a comment
There was a problem hiding this comment.
Do you think we should add a comment to the header for the get_current_protocol_version() function as a reminder to verify the apply_to_state_command tool works with the new protocol version?
| auto transact = bool(flx_sync_arg) ? local_db->start_write() : local_db->start_read(); | ||
| TransactionRef tr; | ||
| switch (download_message.batch_state) { | ||
| case realm::sync::DownloadBatchState::SteadyState: |
There was a problem hiding this comment.
Is it OK that these changes aren't backwards compatible with sync messages from before sync protocol version 14? I am assuming so, since the history.integrate_server_changesets() function isn't going to work with older messages since it is explicitly looking for the DownloadBatchState::SteadyState value that was introduced in version 14.
Perhaps we should include the get_current_protocol_version() output in the help text to indicate which protocol version "should" be supported?
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed