Rules.Idomatic: update switch for new macro enumerator#5142
Closed
compnerd wants to merge 1 commit intorealm:mainfrom
Closed
Rules.Idomatic: update switch for new macro enumerator#5142compnerd wants to merge 1 commit intorealm:mainfrom
macro enumerator#5142compnerd wants to merge 1 commit intorealm:mainfrom
Conversation
The introduction of the `macro` enumerator in the enumeration causes a build break due to an uncovered switch. Conservatively treat the macros as being exempt from the ACLing.
Here's an example of your CHANGELOG entry: * Rules.Idomatic: update switch for new `macro` enumerator.
[compnerd](https://github.com/compnerd)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Collaborator
Contributor
Author
|
@SimplyDanny sounds good! BTW, I wouldn't mind some early feedback on #5030 (I'm happy to split that into separate PRs, but want to gauge the interest and any easy things that can be addressed up front). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of the
macroenumerator in the enumeration causes a build break due to an uncovered switch. Conservatively treat the macros as being exempt from the ACLing.