Skip to content
This repository was archived by the owner on Dec 17, 2017. It is now read-only.

rShell work#7

Open
sdever wants to merge 2 commits intoreactos:masterfrom
sdever:shell-work
Open

rShell work#7
sdever wants to merge 2 commits intoreactos:masterfrom
sdever:shell-work

Conversation

@sdever
Copy link
Copy Markdown
Member

@sdever sdever commented Mar 26, 2016

This brings to life an almost fully-featured folder treeview implementation, along with basic explorer bar infrastructure needed to host it. It also implements the "Explorer bars" menu items and basic explorer band caching abilities.

This means that ReactOS Explorer is now able to load third-party explorer bands.

@ghost
Copy link
Copy Markdown

ghost commented Mar 27, 2016

Wow! Nice work, for me it's ready To go!

travellog.cpp
utility.cpp
CProgressDialog.cpp
comcat.cpp
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent with spaces.

@Swyter
Copy link
Copy Markdown
Member

Swyter commented Mar 27, 2016

Holy guacamole! I wish I were more proficient on the shell-side of things to help you review it.
Anyway, pretty pumped up for this. Just a quick note to let you know that we value your work.

ReactOS needed more contributions of this caliber.

case 0x12:
// refresh on toolbar clicked
return S_OK;
case 0x26:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these undocumented?
Can we create defines for them?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even sure those values are really correct (it's sometimes hard and confusing to understand API Monitor traces)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants