This repository was archived by the owner on Dec 17, 2017. It is now read-only.
[USBOHCI_NEW] Bring-in the USB OHCI miniport driver created by Vadim Galyant.#30
Open
AmineKhaldi wants to merge 196 commits intoreactos:usbohci_newfrom
Open
[USBOHCI_NEW] Bring-in the USB OHCI miniport driver created by Vadim Galyant.#30AmineKhaldi wants to merge 196 commits intoreactos:usbohci_newfrom
AmineKhaldi wants to merge 196 commits intoreactos:usbohci_newfrom
Conversation
AmineKhaldi
requested review from
ColinFinck,
HBelusca,
HeisSpiter,
ThFabba,
bragin,
gigaherz,
janderwald,
learn-more,
tkreuzer and
zefklop
janderwald
reviewed
Jul 2, 2017
| // &OperationalRegs->HcRhPortStatus[Port-1].AsULONG); | ||
|
|
||
| if ( portStatus && !(portStatus & 0xFFE0FCE0) ) | ||
| break; |
Collaborator
There was a problem hiding this comment.
What is status 0xFFE0FCE0 ?
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 2); |
Collaborator
There was a problem hiding this comment.
Please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 4); |
Collaborator
There was a problem hiding this comment.
Please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 1); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 0x200); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 8); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 0x20000); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 0x10000); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 0x100000); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| OperationalRegs = OhciExtension->OperationalRegs; | ||
|
|
||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 0x40000); |
Collaborator
There was a problem hiding this comment.
please use a constant for this
janderwald
reviewed
Jul 2, 2017
| if (Port) | ||
| { | ||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhPortStatus[Port-1].AsULONG, | ||
| 0x80000); |
janderwald
reviewed
Jul 2, 2017
| else | ||
| { | ||
| WRITE_REGISTER_ULONG(&OperationalRegs->HcRhStatus.AsULONG, | ||
| 0x20000); |
janderwald
reviewed
Jul 2, 2017
| DPRINT("OHCI_RH_DisableIrq: OhciExtension - %p\n", OhciExtension); | ||
|
|
||
| WRITE_REGISTER_ULONG(&OhciExtension->OperationalRegs->HcInterruptDisable.AsULONG, | ||
| 0x40); |
janderwald
reviewed
Jul 2, 2017
| DPRINT("OHCI_RH_EnableIrq: OhciExtension - %p\n", OhciExtension); | ||
|
|
||
| WRITE_REGISTER_ULONG(&OhciExtension->OperationalRegs->HcInterruptEnable.AsULONG, | ||
| 0x40); |
janderwald
reviewed
Jul 2, 2017
| { | ||
| InsertHeadList(HeadLink, &ED->HcdEDLink); | ||
|
|
||
| if (HeadED->Type & 0x20) // ControlTransfer or BulkTransfer |
janderwald
reviewed
Jul 2, 2017
| DPRINT_OHCI("OHCI_QueryEndpointRequirements: IsoTransfer\n"); | ||
| *((PULONG)EndpointRequirements + 1) = 0x10000; | ||
| *EndpointRequirements = sizeof(OHCI_HCD_ED) + | ||
| 0x40 * sizeof(OHCI_HCD_TD); |
janderwald
reviewed
Jul 2, 2017
| DPRINT_OHCI("OHCI_QueryEndpointRequirements: ControlTransfer\n"); | ||
| *((PULONG)EndpointRequirements + 1) = 0x10000; | ||
| *EndpointRequirements = sizeof(OHCI_HCD_ED) + | ||
| 0x26 * sizeof(OHCI_HCD_TD); |
ThFabba
reviewed
Nov 23, 2017
| NTAPI | ||
| OHCI_SubmitTransfer(IN PVOID ohciExtension, | ||
| IN PVOID ohciEndpoint, | ||
| IN PVOID transferParameters, |
Member
There was a problem hiding this comment.
I missed this the first time around: should this always be PUSBPORT_TRANSFER_PARAMETERS?
ThFabba
reviewed
Nov 23, 2017
| IN PVOID ohciEndpoint, | ||
| IN PVOID transferParameters, | ||
| IN PVOID ohciTransfer, | ||
| IN PVOID sgList) |
Member
There was a problem hiding this comment.
... and this PUSBPORT_SCATTER_GATHER_LIST?
ThFabba
reviewed
Nov 23, 2017
| NTAPI | ||
| OHCI_SubmitIsoTransfer(IN PVOID ohciExtension, | ||
| IN PVOID ohciEndpoint, | ||
| IN PVOID transferParameters, |
Member
There was a problem hiding this comment.
... and the same here for SubmitIsoTransfer?
ThFabba
reviewed
Nov 23, 2017
| OhciExtension, | ||
| Port); | ||
|
|
||
| ASSERT(Port >= 0); |
Member
There was a problem hiding this comment.
The issue here got fixed by moving the StatusReg assignment inside each if block. The assert is not needed (and is a tautology since USHORT is always >= 0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.