rubocop --only Style/StringLiterals -a

Author: BookOfGreg

Appraisals

@@ -1,97 +1,97 @@
-appraise "rails-3.2" do
+appraise 'rails-3.2' do
   gem 'rails', '~> 3.2.21'
   gem 'rack-cache', '~> 1.6.1'
   # Modern turbolinks depends on `Rails.application.assets` which no-worky
   gem 'turbolinks', '~> 2.0'
 end
 
-appraise "rails-4.0.5" do
+appraise 'rails-4.0.5' do
   # Depends on sprockets-rails ~> 2.0.0. Support for
   # `Rails.application.assets_manifest` which is used by
   # `ServerRendering::ManifestContainer` has only been added in
   # sprockets-rails 2.2.2. Ensure that server rendering falls back to
   # `ServerRendering::EnvironmentContainer`.`
   gem 'rails', '4.0.5'
-  gem "turbolinks"
+  gem 'turbolinks'
 end
 
-appraise "rails-4.0-with-therubyracer" do
+appraise 'rails-4.0-with-therubyracer' do
   gem 'rails', '~> 4.0.13'
   gem 'therubyracer', '0.12.0', :platform => :mri
-  gem "turbolinks"
+  gem 'turbolinks'
 end
 
-appraise "rails-4.1" do
+appraise 'rails-4.1' do
   gem 'rails', '~> 4.1.10'
   # Just to make sure we support old Turbolinks:
-  gem "turbolinks", "~> 2.3.0"
+  gem 'turbolinks', '~> 2.3.0'
 end
 
-appraise "rails-4.2-sprockets_2" do
+appraise 'rails-4.2-sprockets_2' do
   gem 'rails', '~> 4.2.1'
-  gem "sprockets", "~> 2.12"
-  gem "turbolinks"
+  gem 'sprockets', '~> 2.12'
+  gem 'turbolinks'
 end
 
-appraise "rails-4.2-sprockets_3" do
+appraise 'rails-4.2-sprockets_3' do
   gem 'rails', '~> 4.2.1'
-  gem "sprockets", "~> 3.5"
-  gem "turbolinks", "~> 2.5.0"
+  gem 'sprockets', '~> 3.5'
+  gem 'turbolinks', '~> 2.5.0'
 end
 
-appraise "rails-4.2-sprockets_4" do
+appraise 'rails-4.2-sprockets_4' do
   gem 'rails', '~> 4.2.1'
-  gem "sprockets", "~> 4.0.x"
-  gem "turbolinks", "~> 2.5.0"
+  gem 'sprockets', '~> 4.0.x'
+  gem 'turbolinks', '~> 2.5.0'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
-  gem "mini_racer"
+  gem 'mini_racer'
 end
 
 # no_sprockets is a magical name from sprockets_helper.rb in test to
 #   load in certain tests or not.
-appraise "rails-5_no_sprockets_webpacker_1_1" do
+appraise 'rails-5_no_sprockets_webpacker_1_1' do
   gem 'rails', '~> 5.0.0'
-  gem "webpacker", '~> 1.1.0'
+  gem 'webpacker', '~> 1.1.0'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
-  gem "therubyracer"
+  gem 'therubyracer'
 end
 
-appraise "rails-5_no_sprockets_webpacker_1_x" do
+appraise 'rails-5_no_sprockets_webpacker_1_x' do
   gem 'rails', '~> 5.0.0'
-  gem "webpacker", '~> 1.2'
+  gem 'webpacker', '~> 1.2'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
-  gem "therubyracer"
+  gem 'therubyracer'
 end
 
-appraise "rails-5_no_sprockets_webpacker_2" do
+appraise 'rails-5_no_sprockets_webpacker_2' do
   gem 'rails', '~> 5.0.0'
-  gem "webpacker", '~> 2.0'
+  gem 'webpacker', '~> 2.0'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
-  gem "therubyracer"
+  gem 'therubyracer'
 end
 
-appraise "rails-5_no_sprockets_webpacker_3" do
+appraise 'rails-5_no_sprockets_webpacker_3' do
   gem 'rails', '~> 5.0.0'
   gem 'webpacker', '>= 3.0'
   # This ExecJS backend provides stateful context
   # which the default nodejs backend does not
-  gem "therubyracer"
+  gem 'therubyracer'
 end
 
-appraise "rails-5-no_sprockets" do
+appraise 'rails-5-no_sprockets' do
   # Appraisal adds `turbolinks` to this gemfile because it is
   # present in `./Gemfile`.
   # But it causes this gemfile to break, so it must be removed
   # from `./gemfiles/rails_5_no_sprockets.gemfile` manually.
   gem 'rails', '~> 5.0.0'
 end
 
-appraise "rails-5.1-sprockets_4" do
-  gem "rails", "~> 5.1"
-  gem "sprockets", "~> 4.0.x"
-  gem "turbolinks", "~> 5.0.0"
+appraise 'rails-5.1-sprockets_4' do
+  gem 'rails', '~> 5.1'
+  gem 'sprockets', '~> 4.0.x'
+  gem 'turbolinks', '~> 5.0.0'
 end

Rakefile

@@ -20,17 +20,17 @@ def yarn_run_in(dirname, cmd)
 end
 
 namespace :react do
-  desc "Run the JS build process to put files in the gem source"
+  desc 'Run the JS build process to put files in the gem source'
   task update: [:install, :build, :copy]
 
-  desc "Build the JS bundles with Webpack"
+  desc 'Build the JS bundles with Webpack'
   task :build do
-    yarn_run_in("react-builds", "build")
+    yarn_run_in('react-builds', 'build')
   end
 
   desc "Copy browser-ready JS files to the gem's asset paths"
   task :copy do
-    environments = ["development", "production"]
+    environments = ['development', 'production']
     environments.each do |environment|
       # Without addons:
       copy_react_asset("#{environment}/react-browser.js", "#{environment}/react.js")
@@ -42,37 +42,37 @@ namespace :react do
     end
   end
 
-  desc "Install the JavaScript dependencies"
+  desc 'Install the JavaScript dependencies'
   task :install do
-    yarn_run_in("react-builds", "upgrade")
+    yarn_run_in('react-builds', 'upgrade')
   end
 end
 
 namespace :ujs do
-  desc "Run the JS build process to put files in the gem source"
+  desc 'Run the JS build process to put files in the gem source'
   task update: [:install, :build, :copy]
 
-  desc "Install the JavaScript dependencies"
+  desc 'Install the JavaScript dependencies'
   task :install do
-    yarn_run_in("react_ujs", "upgrade")
+    yarn_run_in('react_ujs', 'upgrade')
   end
 
 
-  desc "Build the JS bundles with Webpack"
+  desc 'Build the JS bundles with Webpack'
   task :build do
-    yarn_run_in("react_ujs", "build")
+    yarn_run_in('react_ujs', 'build')
   end
 
   desc "Copy browser-ready JS files to the gem's asset paths"
   task :copy do
-    full_webpack_path = File.expand_path("../react_ujs/dist/react_ujs.js", __FILE__)
-    full_destination_path = File.expand_path("../lib/assets/javascripts/react_ujs.js", __FILE__)
+    full_webpack_path = File.expand_path('../react_ujs/dist/react_ujs.js', __FILE__)
+    full_destination_path = File.expand_path('../lib/assets/javascripts/react_ujs.js', __FILE__)
     FileUtils.cp(full_webpack_path, full_destination_path)
   end
 
-  desc "Publish the package in ./react_ujs/ to npm as `react_ujs`"
+  desc 'Publish the package in ./react_ujs/ to npm as `react_ujs`'
   task publish: :update do
-    Dir.chdir("react_ujs") do
+    Dir.chdir('react_ujs') do
       `npm publish`
     end
   end
@@ -92,16 +92,16 @@ end
 task default: :test
 
 task :test_setup do
-  Dir.chdir("./test/dummy_sprockets") do
+  Dir.chdir('./test/dummy_sprockets') do
     `yarn install`
   end
-  Dir.chdir("./test/dummy_webpacker1") do
+  Dir.chdir('./test/dummy_webpacker1') do
     `yarn install`
   end
-  Dir.chdir("./test/dummy_webpacker2") do
+  Dir.chdir('./test/dummy_webpacker2') do
     `yarn install`
   end
-  Dir.chdir("./test/dummy_webpacker3") do
+  Dir.chdir('./test/dummy_webpacker3') do
     `yarn install`
   end
 end

lib/generators/react/component_generator.rb

@@ -48,7 +48,7 @@ class ComponentGenerator < ::Rails::Generators::NamedBase
       argument :attributes,
                :type => :array,
                :default => [],
-               :banner => "field[:type] field[:type] ..."
+               :banner => 'field[:type] field[:type] ...'
 
       class_option :es6,
                    type: :boolean,
@@ -61,29 +61,29 @@ class ComponentGenerator < ::Rails::Generators::NamedBase
                    desc: 'Output coffeescript based component'
 
       REACT_PROP_TYPES = {
-        "node" =>        'React.PropTypes.node',
-        "bool" =>        'React.PropTypes.bool',
-        "boolean" =>     'React.PropTypes.bool',
-        "string" =>      'React.PropTypes.string',
-        "number" =>      'React.PropTypes.number',
-        "object" =>      'React.PropTypes.object',
-        "array" =>       'React.PropTypes.array',
-        "shape" =>       'React.PropTypes.shape({})',
-        "element" =>     'React.PropTypes.element',
-        "func" =>        'React.PropTypes.func',
-        "function" =>    'React.PropTypes.func',
-        "any" =>         'React.PropTypes.any',
-
-        "instanceOf" => ->(type) {
+        'node' =>        'React.PropTypes.node',
+        'bool' =>        'React.PropTypes.bool',
+        'boolean' =>     'React.PropTypes.bool',
+        'string' =>      'React.PropTypes.string',
+        'number' =>      'React.PropTypes.number',
+        'object' =>      'React.PropTypes.object',
+        'array' =>       'React.PropTypes.array',
+        'shape' =>       'React.PropTypes.shape({})',
+        'element' =>     'React.PropTypes.element',
+        'func' =>        'React.PropTypes.func',
+        'function' =>    'React.PropTypes.func',
+        'any' =>         'React.PropTypes.any',
+
+        'instanceOf' => ->(type) {
           'React.PropTypes.instanceOf(%s)' % type.to_s.camelize
         },
 
-        "oneOf" => ->(*options) {
+        'oneOf' => ->(*options) {
           enums = options.map{|k| "'#{k.to_s}'"}.join(',')
           'React.PropTypes.oneOf([%s])' % enums
         },
 
-        "oneOfType" => ->(*options) {
+        'oneOfType' => ->(*options) {
           types = options.map{|k| "#{lookup(k.to_s, k.to_s)}" }.join(',')
           'React.PropTypes.oneOfType([%s])' % types
         },
@@ -102,9 +102,9 @@ def create_component_file
         # Prefer webpacker to sprockets:
         if webpacker?
           new_file_name = file_name.camelize
-          extension = options[:coffee] ? "coffee" : "js"
+          extension = options[:coffee] ? 'coffee' : 'js'
           target_dir = webpack_configuration.source_path
-            .join("components")
+            .join('components')
             .relative_path_from(::Rails.root)
             .to_s
         else
@@ -131,15 +131,15 @@ def file_header
         if webpacker?
           %|var React = require("react")\n|
         else
-          ""
+          ''
         end
       end
 
       def file_footer
         if webpacker?
           %|module.exports = #{component_name}|
         else
-          ""
+          ''
         end
       end
 
@@ -149,7 +149,7 @@ def webpacker?
 
        def parse_attributes!
          self.attributes = (attributes || []).map do |attr|
-           name, type, options = "", "", ""
+           name, type, options = '', '', ''
            options_regex = /(?<options>{.*})/
 
            name, type = attr.split(':')
@@ -163,7 +163,7 @@ def parse_attributes!
          end
        end
 
-       def self.lookup(type = "node", options = "")
+       def self.lookup(type = 'node', options = '')
          react_prop_type = REACT_PROP_TYPES[type]
          if react_prop_type.blank?
            if type =~ /^[[:upper:]]/
@@ -179,7 +179,7 @@ def self.lookup(type = "node", options = "")
          react_prop_type
        end
 
-       def lookup(type = "node", options = "")
+       def lookup(type = 'node', options = '')
          self.class.lookup(type, options)
        end
     end

lib/generators/react/install_generator.rb

@@ -42,13 +42,13 @@ def create_server_rendering
         if options[:skip_server_rendering]
           return
         elsif webpacker?
-          ssr_manifest_path = File.join(javascript_dir, "server_rendering.js")
-          template("server_rendering_pack.js", ssr_manifest_path)
+          ssr_manifest_path = File.join(javascript_dir, 'server_rendering.js')
+          template('server_rendering_pack.js', ssr_manifest_path)
         else
-          ssr_manifest_path = File.join(javascript_dir, "server_rendering.js")
-          template("server_rendering.js", ssr_manifest_path)
-          initializer_path = "config/initializers/react_server_rendering.rb"
-          template("react_server_rendering.rb", initializer_path)
+          ssr_manifest_path = File.join(javascript_dir, 'server_rendering.js')
+          template('server_rendering.js', ssr_manifest_path)
+          initializer_path = 'config/initializers/react_server_rendering.rb'
+          template('react_server_rendering.rb', initializer_path)
         end
       end
 
@@ -90,7 +90,7 @@ def setup_react_sprockets
         end
 
         components_js = "//= require_tree ./components\n"
-        components_file = File.join(javascript_dir, "components.js")
+        components_file = File.join(javascript_dir, 'components.js')
         create_file components_file, components_js
       end
 

lib/generators/templates/react_server_rendering.rb

@@ -1,2 +1,2 @@
 # To render React components in production, precompile the server rendering manifest:
-Rails.application.config.assets.precompile += ["server_rendering.js"]
+Rails.application.config.assets.precompile += ['server_rendering.js']

lib/react/jsx/babel_transformer.rb

@@ -7,8 +7,8 @@ class BabelTransformer
       DEFAULT_TRANSFORM_OPTIONS = { blacklist: ['spec.functionName', 'validation.react', 'strict'] }
       def initialize(options)
         if (options.keys & DEPRECATED_OPTIONS).any?
-          ActiveSupport::Deprecation.warn("Setting config.react.jsx_transform_options for :harmony, :strip_types, and :asset_path keys is now deprecated and has no effect with the default Babel Transformer."+
-                                              "Please use new Babel Transformer options :whitelist, :plugin instead.")
+          ActiveSupport::Deprecation.warn('Setting config.react.jsx_transform_options for :harmony, :strip_types, and :asset_path keys is now deprecated and has no effect with the default Babel Transformer.'+
+                                              'Please use new Babel Transformer options :whitelist, :plugin instead.')
         end
 
         @transform_options = DEFAULT_TRANSFORM_OPTIONS.merge(options)

lib/react/jsx/jsx_transformer.rb

@@ -21,7 +21,7 @@ def initialize(options)
 
       def transform(code)
         result = @context.call('JSXTransformer.transform', code, @transform_options)
-        result["code"]
+        result['code']
       end
 
       # search for transformer file using sprockets - allows user to override