Skip to content

Commit 0f75fe7

Browse files
committed
rubocop --only Layout/SpaceInsideHashLiteralBraces -a
1 parent e3efcb8 commit 0f75fe7

13 files changed

+39
-39
lines changed

lib/react/rails/component_mount.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def teardown(controller)
2424
# are used by react_ujs to actually instantiate the React component
2525
# on the client.
2626
def react_component(name, props = {}, options = {}, &block)
27-
options = {:tag => options} if options.is_a?(Symbol)
27+
options = { :tag => options } if options.is_a?(Symbol)
2828
if options.fetch(:camelize_props, camelize_props_switch)
2929
props = React.camelize_props(props)
3030
end

lib/react/server_rendering.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module ServerRendering
1313
# This will clear all state such as loaded code, JS VM state, or options.
1414
# @return [void]
1515
def self.reset_pool
16-
options = {size: pool_size, timeout: pool_timeout}
16+
options = { size: pool_size, timeout: pool_timeout }
1717
@@pool = ConnectionPool.new(options) { self.renderer.new(self.renderer_options) }
1818
end
1919

test/react/jsx/jsx_transformer_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class JSXTransformerTest < ActionDispatch::IntegrationTest
2828
end
2929

3030
test 'accepts harmony: true option' do
31-
React::JSX.transform_options = {harmony: true}
31+
React::JSX.transform_options = { harmony: true }
3232
get '/assets/harmony_example.js'
3333
assert_response :success
3434
assert_match(/generateGreeting:\s*function\(\)/, @response.body, "object literal methods")
@@ -38,7 +38,7 @@ class JSXTransformerTest < ActionDispatch::IntegrationTest
3838
end
3939

4040
test 'accepts strip_types: true option' do
41-
React::JSX.transform_options = {strip_types: true, harmony: true}
41+
React::JSX.transform_options = { strip_types: true, harmony: true }
4242
get '/assets/flow_types_example.js'
4343
assert_response :success
4444
assert_match(/\(i\s*,\s*name\s*\)\s*\{/, @response.body, "type annotations are removed")
@@ -49,7 +49,7 @@ class JSXTransformerTest < ActionDispatch::IntegrationTest
4949
custom_path = Rails.root.join("vendor/assets/react/custom")
5050
replacing_path = custom_path.join("CustomTransformer.js")
5151

52-
React::JSX.transform_options = {asset_path: "custom/CustomTransformer.js"}
52+
React::JSX.transform_options = { asset_path: "custom/CustomTransformer.js" }
5353

5454
FileUtils.mkdir_p(custom_path)
5555
FileUtils.cp(hidden_path, replacing_path)

test/react/jsx_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class JSXTransformTest < ActionDispatch::IntegrationTest
5959
end
6060

6161
def test_babel_transformer_accepts_babel_transformation_options
62-
React::JSX.transform_options = {blacklist: ['spec.functionName', 'validation.react', "strict"]}
62+
React::JSX.transform_options = { blacklist: ['spec.functionName', 'validation.react', "strict"] }
6363
SprocketsHelpers.manually_expire_asset('example.js')
6464
get '/assets/example.js'
6565
assert_response :success

test/react/rails/component_mount_test.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class ComponentMountTest < ActionDispatch::IntegrationTest
1212
end
1313

1414
test '#react_component accepts React props' do
15-
html = @helper.react_component('Foo', {bar: 'value'})
15+
html = @helper.react_component('Foo', { bar: 'value' })
1616
expected_props = %w(data-react-class="Foo" data-react-props="{&quot;bar&quot;:&quot;value&quot;}")
1717
expected_props.each do |segment|
1818
assert html.include?(segment)
@@ -22,7 +22,7 @@ class ComponentMountTest < ActionDispatch::IntegrationTest
2222
test '#react_component accepts React props with camelize_props' do
2323
React::Rails::ComponentMount.camelize_props_switch = true
2424
helper = React::Rails::ComponentMount.new
25-
html = helper.react_component('Foo', {foo_bar: 'value'})
25+
html = helper.react_component('Foo', { foo_bar: 'value' })
2626
expected_props = %w(data-react-class="Foo" data-react-props="{&quot;fooBar&quot;:&quot;value&quot;}")
2727
expected_props.each do |segment|
2828
assert html.include?(segment)
@@ -32,15 +32,15 @@ class ComponentMountTest < ActionDispatch::IntegrationTest
3232
test '#react_component allows camelize_props to be passed in as an option' do
3333
React::Rails::ComponentMount.camelize_props_switch = false
3434
helper = React::Rails::ComponentMount.new
35-
html = helper.react_component('Foo', {foo_bar: 'value'}, camelize_props: true)
35+
html = helper.react_component('Foo', { foo_bar: 'value' }, camelize_props: true)
3636
expected_props = %w(data-react-class="Foo" data-react-props="{&quot;fooBar&quot;:&quot;value&quot;}")
3737
expected_props.each do |segment|
3838
assert html.include?(segment)
3939
end
4040

4141
React::Rails::ComponentMount.camelize_props_switch = true
4242
helper = React::Rails::ComponentMount.new
43-
html = helper.react_component('Foo', {foo_bar: 'value'}, camelize_props: false)
43+
html = helper.react_component('Foo', { foo_bar: 'value' }, camelize_props: false)
4444
expected_props = %w(data-react-class="Foo" data-react-props="{&quot;foo_bar&quot;:&quot;value&quot;}")
4545
expected_props.each do |segment|
4646
assert html.include?(segment)
@@ -50,7 +50,7 @@ class ComponentMountTest < ActionDispatch::IntegrationTest
5050
test '#react_component accepts React props with camelize_props containing nested arrays' do
5151
React::Rails::ComponentMount.camelize_props_switch = true
5252
helper = React::Rails::ComponentMount.new
53-
html = helper.react_component('Foo', {foo_bar: [{user_name: 'Ryan'}, {user_name: 'Matt'}], bar_foo: 1})
53+
html = helper.react_component('Foo', { foo_bar: [{ user_name: 'Ryan' }, { user_name: 'Matt' }], bar_foo: 1 })
5454
expected_props = %w(data-react-class="Foo" data-react-props="{&quot;fooBar&quot;:[{&quot;userName&quot;:&quot;Ryan&quot;},{&quot;userName&quot;:&quot;Matt&quot;}],&quot;barFoo&quot;:1}")
5555
expected_props.each do |segment|
5656
assert html.include?(segment)
@@ -70,27 +70,27 @@ class ComponentMountTest < ActionDispatch::IntegrationTest
7070
end
7171

7272
test '#react_component accepts string props with prerender: true' do
73-
html = @helper.react_component('Todo', {todo: 'render on the server'}.to_json, prerender: true)
73+
html = @helper.react_component('Todo', { todo: 'render on the server' }.to_json, prerender: true)
7474
assert(html.include?('data-react-class="Todo"'), "it includes attrs for UJS")
7575
assert(html.include?('>render on the server</li>'), "it includes rendered HTML")
7676
assert(html.include?('data-reactid'), "it includes React properties")
7777
end
7878

7979
test '#react_component passes :static to BundleRenderer' do
80-
html = @helper.react_component('Todo', {todo: 'render on the server'}.to_json, prerender: :static)
80+
html = @helper.react_component('Todo', { todo: 'render on the server' }.to_json, prerender: :static)
8181
assert(html.include?('>render on the server</li>'), "it includes rendered HTML")
8282
assert(!html.include?('data-reactid'), "it DOESNT INCLUDE React properties")
8383
end
8484

8585
test '#react_component does not include HTML properties with a static render' do
86-
html = @helper.react_component('Todo', {todo: 'render on the server'}.to_json, prerender: :static)
86+
html = @helper.react_component('Todo', { todo: 'render on the server' }.to_json, prerender: :static)
8787
assert_equal('<div><li>render on the server</li></div>', html)
8888
end
8989

9090
test '#react_component accepts HTML options and HTML tag' do
9191
assert @helper.react_component('Foo', {}, :span).match(/<span\s.*><\/span>/)
9292

93-
html = @helper.react_component('Foo', {}, {class: 'test', tag: :span, data: {foo: 1}})
93+
html = @helper.react_component('Foo', {}, { class: 'test', tag: :span, data: { foo: 1 } })
9494
assert html.match(/<span\s.*><\/span>/)
9595
assert html.include?('class="test"')
9696
assert html.include?('data-foo="1"')
@@ -110,7 +110,7 @@ def self.react_rails_prerenderer
110110

111111
test "it uses the controller's react_rails_prerenderer, if available" do
112112
@helper.setup(DummyController)
113-
rendered_component = @helper.react_component('Foo', {"ok" => true}, prerender: :static)
113+
rendered_component = @helper.react_component('Foo', { "ok" => true }, prerender: :static)
114114
assert_equal %|<div>rendered Foo with {&quot;ok&quot;:true}</div>|, rendered_component
115115
end
116116
end

test/react/rails/view_helper_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,13 @@ class ViewHelperHelper
1111
class ViewHelperTest < ActionView::TestCase
1212
test "view helper can be called directly" do
1313
expected_html = %{<div data-react-class="Component" data-react-props="{&quot;a&quot;:&quot;b&quot;}"></div>}
14-
rendered_html = ViewHelperHelper.react_component("Component", {a: "b"})
14+
rendered_html = ViewHelperHelper.react_component("Component", { a: "b" })
1515
assert_equal(expected_html, rendered_html)
1616
end
1717

1818
test 'view helper accepts block usage' do
1919
expected_html = %{<div data-react-class="Component" data-react-props="{&quot;a&quot;:&quot;b&quot;}">content</div>}
20-
rendered_html = ViewHelperHelper.react_component("Component", {a: "b"}) do
20+
rendered_html = ViewHelperHelper.react_component("Component", { a: "b" }) do
2121
"content"
2222
end
2323
assert_equal(expected_html, rendered_html)

test/react/server_rendering/bundle_renderer_test.rb

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -31,33 +31,33 @@ class BundleRendererTest < ActiveSupport::TestCase
3131
end
3232

3333
test '#render returns HTML' do
34-
result = @renderer.render("Todo", {todo: "write tests"}, nil)
34+
result = @renderer.render("Todo", { todo: "write tests" }, nil)
3535
assert_match(/<li.*write tests<\/li>/, result)
3636
assert_match(/data-react-checksum/, result)
3737
end
3838

3939
test '#render accepts strings' do
40-
result = @renderer.render("Todo", {todo: "write more tests"}.to_json, nil)
40+
result = @renderer.render("Todo", { todo: "write more tests" }.to_json, nil)
4141
assert_match(/<li.*write more tests<\/li>/, result)
4242
end
4343

4444
test '#render accepts :static pre-render option' do
45-
result = @renderer.render("Todo", {todo: "write more tests"}, :static)
45+
result = @renderer.render("Todo", { todo: "write more tests" }, :static)
4646
assert_match(/<li>write more tests<\/li>/, result)
4747
assert_no_match(/data-react-checksum/, result)
4848
end
4949

5050
test '#render replays console messages' do
51-
result = @renderer.render("TodoListWithConsoleLog", {todos: ["log some messages"]}, nil)
51+
result = @renderer.render("TodoListWithConsoleLog", { todos: ["log some messages"] }, nil)
5252
assert_match(/<script class="react-rails-console-replay">$/, result)
5353
assert_match(/console.log.apply\(console, \["got initial state"\]\);$/, result)
5454
assert_match(/console.warn.apply\(console, \["mounted component"\]\);$/, result)
5555
assert_match(/console.error.apply\(console, \["rendered!","foo"\]\);$/, result)
5656
end
5757

5858
test '#render console messages can be disabled' do
59-
no_log_renderer = React::ServerRendering::BundleRenderer.new({replay_console: false})
60-
result = no_log_renderer.render("TodoListWithConsoleLog", {todos: ["log some messages"]}, nil)
59+
no_log_renderer = React::ServerRendering::BundleRenderer.new({ replay_console: false })
60+
result = no_log_renderer.render("TodoListWithConsoleLog", { todos: ["log some messages"] }, nil)
6161
assert_no_match(/console.log.apply\(console, \["got initial state"\]\)/, result)
6262
assert_no_match(/console.warn.apply\(console, \["mounted component"\]\)/, result)
6363
assert_no_match(/console.error.apply\(console, \["rendered!","foo"\]\)/, result)
@@ -97,15 +97,15 @@ class BundleRendererTest < ActiveSupport::TestCase
9797

9898
additional_renderer = React::ServerRendering::BundleRenderer.new(code: additional_code)
9999

100-
assert_match(/drink more caffeine<\/span>/, additional_renderer.render("WithoutSprockets", {label: "drink more caffeine"}, nil))
100+
assert_match(/drink more caffeine<\/span>/, additional_renderer.render("WithoutSprockets", { label: "drink more caffeine" }, nil))
101101
end
102102

103103
# These use cases don't apply to Webpacker since the require.context comes from a pack:
104104
test '.new accepts any filenames' do
105105
limited_renderer = React::ServerRendering::BundleRenderer.new(files: ["react-server.js", "react_ujs.js", "components/Todo.js"])
106-
assert_match(/get a real job<\/li>/, limited_renderer.render("Todo", {todo: "get a real job"}, nil))
106+
assert_match(/get a real job<\/li>/, limited_renderer.render("Todo", { todo: "get a real job" }, nil))
107107
err = assert_raises React::ServerRendering::PrerenderError do
108-
limited_renderer.render("TodoList", {todos: []}, nil)
108+
limited_renderer.render("TodoList", { todos: [] }, nil)
109109
end
110110
assert_match(/ReferenceError/, err.to_s, "it doesnt load other files")
111111
end
@@ -121,7 +121,7 @@ class BundleRendererTest < ActiveSupport::TestCase
121121

122122
@renderer = React::ServerRendering::BundleRenderer.new(files: legacy_rendering_files)
123123

124-
result = @renderer.render("Todo", {todo: "write tests"}, nil)
124+
result = @renderer.render("Todo", { todo: "write tests" }, nil)
125125
assert_match(/<li.*write tests<\/li>/, result)
126126
assert_match(/data-react-checksum/, result)
127127
ensure

test/react/server_rendering/console_replay_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
class ConsoleReplayTest < ActionDispatch::IntegrationTest
55
setup do
66
WebpackerHelpers.compile
7-
React::ServerRendering.renderer_options = {replay_console: true}
7+
React::ServerRendering.renderer_options = { replay_console: true }
88
React::ServerRendering.reset_pool
99
end
1010

test/react/server_rendering/exec_js_renderer_test.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ class ExecJSRendererTest < ActiveSupport::TestCase
2222
end
2323

2424
test '#render returns HTML' do
25-
result = @renderer.render("Todo", {todo: "write tests"}.to_json, {})
25+
result = @renderer.render("Todo", { todo: "write tests" }.to_json, {})
2626
assert_match(/<li.*write tests<\/li>/, result)
2727
assert_match(/data-react-checksum/, result)
2828
end
2929

3030
test '#render accepts render_function:' do
31-
result = @renderer.render("Todo", {todo: "write more tests"}.to_json, render_function: "renderToStaticMarkup")
31+
result = @renderer.render("Todo", { todo: "write more tests" }.to_json, render_function: "renderToStaticMarkup")
3232
assert_match(/<li>write more tests<\/li>/, result)
3333
assert_no_match(/data-react-checksum/, result)
3434
end
@@ -43,7 +43,7 @@ def @renderer.after_render(name, props, opts)
4343
end
4444

4545
error = assert_raises(React::ServerRendering::PrerenderError) do
46-
@renderer.render("Todo", {todo: "write tests"}.to_json, {})
46+
@renderer.render("Todo", { todo: "write tests" }.to_json, {})
4747
end
4848

4949
assert_match(/before_render/, error.message)
@@ -60,7 +60,7 @@ def @renderer.after_render(name, props, opts)
6060
end
6161

6262
error = assert_raises(React::ServerRendering::PrerenderError) do
63-
@renderer.render("Todo", {todo: "write tests"}.to_json, {})
63+
@renderer.render("Todo", { todo: "write tests" }.to_json, {})
6464
end
6565

6666
assert_match(/after_render/, error.message)
@@ -69,7 +69,7 @@ def @renderer.after_render(name, props, opts)
6969

7070
test '.new accepts code:' do
7171
dummy_renderer = React::ServerRendering::ExecJSRenderer.new(code: DUMMY_IMPLEMENTATION)
72-
result = dummy_renderer.render("Todo", {todo: "get a real job"}.to_json, {})
72+
result = dummy_renderer.render("Todo", { todo: "get a real job" }.to_json, {})
7373
assert_equal("serverRender was called", result)
7474
end
7575
end

test/react/server_rendering_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class ReactServerRenderingTest < ActiveSupport::TestCase
2727
end
2828

2929
test '.render returns a rendered string' do
30-
props = {"props" => true}
30+
props = { "props" => true }
3131
result = React::ServerRendering.render("MyComponent", props, "prerender-opts")
3232
assert_equal("TEST rendered MyComponent with #{props} and prerender-opts", result)
3333
end

0 commit comments

Comments
 (0)