Add tests for CamelCaseStringEnumConverter case-insensitive deserialization#2069
Merged
ChrisPulman merged 2 commits intoFixFor2065_2067from Mar 25, 2026
Merged
Add tests for CamelCaseStringEnumConverter case-insensitive deserialization#2069ChrisPulman merged 2 commits intoFixFor2065_2067from
ChrisPulman merged 2 commits intoFixFor2065_2067from
Conversation
2 tasks
…umConverter Co-authored-by: ChrisPulman <4910015+ChrisPulman@users.noreply.github.com> Agent-Logs-Url: https://github.com/reactiveui/refit/sessions/457806a0-8430-40b3-8e4e-26f6590217ff
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on sync interface members & enum names support
Add tests for CamelCaseStringEnumConverter case-insensitive deserialization
Mar 25, 2026
ChrisPulman
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CamelCaseStringEnumConvertergained anamesToValuesIgnoreCasefallback map but had no tests exercising that path, leaving the case-insensitive behavior unverified.Changes
DeserializesEnumValuesWithVariousCasingscovers inputs likevAlUeOnE,ValueOne,VALUEONE, andvalueone, ensuring they all resolve via the case-insensitive path when no exact camelCase match exists.ExactCaseMatchTakesPriorityOverCaseInsensitiveWhenMembersDifferByCaseverifies that when an enum has members differing only by case (Alpha = 1,ALPHA = 2), the case-sensitive lookup takes priority and the correct member is returned for each serialized form ("alpha","aLPHA","Alpha","ALPHA").CaseDifferentMembersenum — helper enum added alongsideCamelCaseEnumto support the disambiguation test.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.