-
-
Notifications
You must be signed in to change notification settings - Fork 333
Fix: tests fail when 'playwright install-deps' has already run #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ne as part of the host/container provisioning.
|
I am refactoring the build process in #1317 so I just want to ask for some additional context. In what scenario/environment is |
|
I'm developing & testing in a container hosted on WSL2/Ubuntu. playwright is installed and 'playwright install-deps' is run in the Dockerfile. |
|
Thanks. I've managed to generate an error with a fresh WSL2 (Ubuntu) instance. Will presume this is the same issue you had: |
|
That message doesn't look familiar. I'm away for the weekend, I'll reproduce the error and get back to you on Monday. Cheers. |
|
I've wound back to ReactPy "2.0.0b4" and restored the Dockerfile to its old state. Dockerfile: ReacytPy Testing: Manually install-deps to see what's going on" |
|
Does |
Description
Fix: tests are failing when
'playwright install-deps'has already been done as part of the host/container provisioning.Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).