chore(lint): use ultracite CLI instead of biome directly#66
Merged
Conversation
Per Ultracite's recommendations, route the scripts and the lefthook hook
through the `ultracite` CLI rather than invoking `biome` directly:
- lint -> `ultracite check ./src`
- format -> `ultracite fix ./src`
- pre-commit hook -> `pnpm ultracite fix {staged_files}` (ultracite already
passes --no-errors-on-unmatched, so the flag is dropped)
Scoped to ./src on purpose: `ultracite check` with no path lints the whole
repo (ultracite/biome/core sets includes to ["**"], which merges over ours),
which would pull in the examples demo. Restricting via a "**" override in
biome.jsonc trips Biome's own noBiomeFirstException rule, so an explicit
path is the clean way to keep the prior src-only scope.
Also remove the dead jest.config.cjs (the suite runs on Vitest; ts-jest is
no longer a dependency and nothing references it).
Dropped the redundant lint:fix script (format already runs ultracite fix).
Verified: lint, format (idempotent), build, 110 tests, tsc, e2e, and the
pre-commit hook all pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
coverage: 91.413%. remained the same — chore/use-ultracite-cli into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #65. Per Ultracite's recommendations (checked via context7), route the lint/format scripts and the lefthook pre-commit hook through the
ultraciteCLI instead of callingbiomedirectly.lint→ultracite check ./srcformat→ultracite fix ./srcpnpm ultracite fix {staged_files}(ultracite already adds--no-errors-on-unmatched)lint:fix(formatalready runsultracite fix)Why
./srcand not the bare command:ultracite checkwith no path lints the whole repo becauseultracite/biome/coresetsincludes: ["**"](which merges over ours), pulling in theexamples/demo. Restricting via a"**"override inbiome.jsonctrips Biome's ownnoBiomeFirstExceptionrule, so an explicit./srcpath is the clean way to preserve the prior src-only scope.Also removes the dead
jest.config.cjs(suite runs on Vitest;ts-jestis gone and nothing references it) — surfaced while running the bare ultracite check.Verified
✅
pnpm lint(ultracite check) · ✅pnpm format(idempotent) · ✅ build · ✅ 110 tests · ✅ tsc · ✅ e2e · ✅ pre-commit hook live test🤖 Generated with Claude Code