Return actual loaded bundle URL from SourceCodeModule#56698
Closed
javache wants to merge 1 commit into
Closed
Conversation
Summary: The C++ `SourceCodeModule` (ReactCxxPlatform) always derived `scriptURL` from `DevServerHelper::getBundleUrl()`, coupling the module to dev infrastructure. This diff replaces that dependency with a simple `std::string` parameter passed at construction time. `ReactHost` and `FoxReactHost` store the source URL in a `shared_ptr<string>` that is updated on each successful dev-server bundle load. When `SourceCodeModule` is instantiated (lazily, after the bundle is loaded), the TurboModule provider dereferences the current value and passes it through as a plain string. For file-based bundle loading the URL is cleared, matching the previous behavior. This decouples `SourceCodeModule` from `DevServerHelper` without introducing lambdas, context container lookups, or shared mutable state in the module itself. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D102669868
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D102669868. |
|
This pull request has been merged in 5b3a1a4. |
Collaborator
|
This pull request was successfully merged by @javache in 5b3a1a4 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The C++
SourceCodeModule(ReactCxxPlatform) always derivedscriptURLfromDevServerHelper::getBundleUrl(), coupling the module to dev infrastructure. This diff replaces that dependency with a simplestd::stringparameter passed at construction time.ReactHostandFoxReactHoststore the source URL in ashared_ptr<string>that is updated on each successful dev-server bundle load. WhenSourceCodeModuleis instantiated (lazily, after the bundle is loaded), the TurboModule provider dereferences the current value and passes it through as a plain string. For file-based bundle loading the URL is cleared, matching the previous behavior.This decouples
SourceCodeModulefromDevServerHelperwithout introducing lambdas, context container lookups, or shared mutable state in the module itself.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D102669868