fix: exception thrown in useMediaQuery when unsupported, add option to disable the hook#1581
Open
rawpixel-vincent wants to merge 1 commit intoreact-hookz:masterfrom
Open
fix: exception thrown in useMediaQuery when unsupported, add option to disable the hook#1581rawpixel-vincent wants to merge 1 commit intoreact-hookz:masterfrom
rawpixel-vincent wants to merge 1 commit intoreact-hookz:masterfrom
Conversation
rawpixel-vincent
force-pushed
the
pr/fix-1580
branch
3 times, most recently
from
fc88edd to
92d8832
Compare
Author
|
please review the test implementation, I've never used vitest before. in the test |
This was referenced Jan 4, 2025
Closed
rawpixel-vincent
force-pushed
the
pr/fix-1580
branch
from
92d8832 to
7ff103c
Compare
…o disable the hook
rawpixel-vincent
force-pushed
the
pr/fix-1580
branch
from
7ff103c to
3f2db52
Compare
rawpixel-vincent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1580 and add an option to allow the match to be disabled conditionally
add tests 🟢