Skip to content

fix(Form): avoid merging sparse list patches into allValue #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QDyanbing wants to merge 2 commits into
base: master
Choose a base branch
from
+32 −0
Open

fix(Form): avoid merging sparse list patches into allValue #771

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0136afb
fix(Form): avoid merging sparse list patches into allValue
QDyanbing Dec 17, 2025
cd345f3
revert: drop mergeWith changes in useForm (not root cause)
QDyanbing Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions tests/list.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,4 +1139,36 @@ describe('Form.List', () => {
{ list: [{ name: 'John', tags: ['react', 'ts', 'redux'] }] },
);
});

it('should not drop list items when updating list item field', async () => {
const onValuesChange = jest.fn();

const { getAllByRole } = render(
<Form onValuesChange={onValuesChange}>
<Form.List
name="list"
initialValue={[{ name: 'A' }, { name: 'B' }, { name: 'C' }, { name: 'D' }]}
>
{fields =>
fields.map(field => (
<Field key={field.key} name={[field.name, 'name']}>
<input />
</Field>
))
}
</Form.List>
</Form>,
);

// Change second item (index = 1)
fireEvent.change(getAllByRole('textbox')[1], {
target: { value: 'BB' },
});

const [, allValues] = onValuesChange.mock.calls.pop();

expect(allValues).toEqual({
list: [{ name: 'A' }, { name: 'BB' }, { name: 'C' }, { name: 'D' }],
});
});
});