-
Notifications
You must be signed in to change notification settings - Fork 26
Rebase with Develop branch #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
65a7559
f710c87
8efac8e
fda6ec5
d16879c
33ed34b
55650a2
f6c6d7d
42da7af
84b8951
36f386d
9257820
a503f9e
974beb6
4a4ea54
a52d864
8e05add
8a97f28
81f4b89
024882a
6750eba
82a6e05
83a1518
a1da8a4
33b4866
c66ef14
8cb0f37
7302ede
25a6735
3202ca6
206d137
c48dff7
3da15c8
29f6789
48461dc
6500318
a2496f0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # These owners will be the default owners for everything in | ||
| # the repo. Unless a later match takes precedence, | ||
| # @global-owner1 and @global-owner2 will be requested for | ||
| # review when someone opens a pull request. | ||
| * @rdkcentral/xdialserver-maintainers |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Build Component in Native Environment | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, 'sprint/**', 'release/**', topic/*, develop ] | ||
| pull_request: | ||
| branches: [ main, 'sprint/**', 'release/**', topic/*, develop ] | ||
|
|
||
| jobs: | ||
| build-entservices-on-pr: | ||
| name: Build xdialserver component in github rdkcentral | ||
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ubuntu:22.04 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: native build | ||
| run: | | ||
| sh -x build_dependencies.sh | ||
| sh -x cov_build.sh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.RDKCM_RDKE }} | ||
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,130 @@ | ||||||
| #!/bin/bash | ||||||
| set -x | ||||||
| set -e | ||||||
| ############################## | ||||||
| GITHUB_WORKSPACE="${PWD}" | ||||||
|
|
||||||
| cd ${GITHUB_WORKSPACE} | ||||||
|
|
||||||
| # # ############################# | ||||||
| #1. Install Dependencies and packages | ||||||
|
|
||||||
| apt update | ||||||
| apt install -y git python3 python3-pip cmake ninja-build meson curl libsoup2.4-dev libxml2-dev libglib2.0-dev gobject-introspection libgirepository1.0-dev libgtk-3-dev libcurl4-openssl-dev libcunit1-dev valac pandoc | ||||||
|
||||||
| apt install -y git python3 python3-pip cmake ninja-build meson curl libsoup2.4-dev libxml2-dev libglib2.0-dev gobject-introspection libgirepository1.0-dev libgtk-3-dev libcurl4-openssl-dev libcunit1-dev valac pandoc | |
| apt install -y git python3 python3-pip cmake ninja-build meson curl libsoup2.4-dev libxml2-dev libglib2.0-dev gobject-introspection libgirepository1.0-dev libgtk-3-dev libcurl4-openssl-dev libcunit1-dev valac pandoc uuid-dev |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| #!/bin/bash | ||
| set -x | ||
| set -e | ||
| ############################## | ||
| GITHUB_WORKSPACE="${PWD}" | ||
| ls -la ${GITHUB_WORKSPACE} | ||
| ############################ | ||
| # Build xdialserver | ||
| echo "buliding xdialserver" | ||
|
|
||
| cd ${GITHUB_WORKSPACE} | ||
|
|
||
| make | ||
|
|
||
| echo "======================================================================================" | ||
| exit 0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,14 +27,20 @@ find_package (PkgConfig REQUIRED) | |
| pkg_search_module (GLIB REQUIRED glib-2.0) | ||
| pkg_search_module (GIO REQUIRED gio-2.0) | ||
| pkg_search_module (GSSDP12 gssdp-1.2) | ||
| pkg_search_module (LIBSOUP3 libsoup-3.0) | ||
| if (GSSDP12_FOUND) | ||
| pkg_search_module (GSSDP REQUIRED gssdp-1.2) | ||
| add_definitions(-DHAVE_GSSDP_VERSION_1_2_OR_NEWER) | ||
| message("Using gssdp-1.2") | ||
| else() | ||
| pkg_search_module (GSSDP REQUIRED gssdp-1.0) | ||
| endif() | ||
| pkg_search_module (SOUP REQUIRED libsoup-2.4) | ||
| if (LIBSOUP3_FOUND) | ||
| pkg_search_module (SOUP REQUIRED libsoup-3.0) | ||
| message("Using libsoup-3.0") | ||
| else() | ||
| pkg_search_module (SOUP REQUIRED libsoup-2.4) | ||
| endif() | ||
|
Comment on lines
+30
to
+43
|
||
| pkg_search_module (XML2 REQUIRED libxml-2.0) | ||
|
|
||
| set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g") | ||
|
|
@@ -101,4 +107,4 @@ target_link_libraries (gdial-server | |
|
|
||
| add_executable (gdial-server-ut gdialserver_ut.cpp) | ||
|
|
||
| target_link_libraries (gdial-server-ut gdial-plat gdial-server) | ||
| target_link_libraries (gdial-server-ut gdial-plat gdial-server) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title suggests this is only a rebase, but the diff includes functional changes (UUID-based app URIs, new manufacturer/model update APIs, security-token build option, libsoup selection changes, CI workflow additions, etc.). Consider updating the PR title/description to reflect the actual scope so reviewers understand the behavioral impact.