Skip to content

RDKEMW-14755-[develop] Observed "tr69hostif" crash with "hostIf_WiFi_EndPoint::refreshCache" function and different fingerprint#393

Merged
nhanasi merged 9 commits intodevelopfrom
topic/RDKEMW-14755
Mar 11, 2026
Merged

RDKEMW-14755-[develop] Observed "tr69hostif" crash with "hostIf_WiFi_EndPoint::refreshCache" function and different fingerprint#393
nhanasi merged 9 commits intodevelopfrom
topic/RDKEMW-14755

Conversation

@Vismalskumar0
Copy link
Copy Markdown
Contributor

@Vismalskumar0 Vismalskumar0 commented Mar 11, 2026 •
edited
Loading

RDKEMW-14755-[develop] Observed "tr69hostif" crash with "hostIf_WiFi_EndPoint::refreshCache" function and different fingerprint

@Vismalskumar0 Vismalskumar0 requested a review from a team as a code owner March 11, 2026 06:16
Copilot AI review requested due to automatic review settings March 11, 2026 06:16
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent crashes in the non-RDKV_NM WiFi EndPoint cache refresh path by adding defensive cJSON type/null checks when parsing NetworkManager JSON-RPC responses.

Changes:

  • Added validation around the interfaces array and WIFI interface selection before reading enabled.
  • Added validation that state is numeric, plus a default case for unknown states.
  • Added validation for ssid and signalStrength types before dereferencing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp Outdated
Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp Outdated
@Vismalskumar0 Vismalskumar0 requested a review from Copilot March 11, 2026 07:04
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp
Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp
Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

@Vismalskumar0 I've opened a new pull request, #394, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Mar 11, 2026
Merged
2 tasks
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

@Vismalskumar0 I've opened a new pull request, #395, to work on those changes. Once the pull request is ready, I'll request review from you.

This was referenced Mar 11, 2026
Merged
Draft
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

@Vismalskumar0 I've opened a new pull request, #396, to work on those changes. Once the pull request is ready, I'll request review from you.

Vismalskumar0 and others added 3 commits March 11, 2026 12:49
@Vismalskumar0
Merge pull request #394 from rdkcentral/copilot/sub-pr-393
c038af8 
[WIP] Address feedback on crash issue checks in original PR
@Vismalskumar0
Fix misleading 'curl init failed' log messages to accurately reflect …
5aee849 
…getJsonRPCData() failure

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
@Vismalskumar0
Merge pull request #395 from rdkcentral/copilot/sub-pr-393-again
0d8ca9c 
Fix misleading log messages in WiFi endpoint RPC response handling
Copilot AI review requested due to automatic review settings March 11, 2026 07:23
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp Outdated
Comment thread src/hostif/profiles/wifi/Device_WiFi_EndPoint.cpp
@Vismalskumar0
Apply suggestion from @Copilot
4ccc7b2 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 11, 2026 07:27
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Vismalskumar0 Vismalskumar0 changed the title Added the checks for the crash issue RDKEMW-14755-[develop] Observed "tr69hostif" crash with "hostIf_WiFi_EndPoint::refreshCache" function and different fingerprint Mar 11, 2026
@nhanasi nhanasi merged commit 4b5fde9 into develop Mar 11, 2026
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@AravindanNC AravindanNC AravindanNC approved these changes

@nhanasi nhanasi nhanasi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Vismalskumar0 @AravindanNC @nhanasi