RDKEMW-16916: Add API to clear CDN access token for AuthService plugin#83
RDKEMW-16916: Add API to clear CDN access token for AuthService plugin#83melhar098 wants to merge 1 commit intosupport/8.5.3.0from
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Yocto middleware IPK feed configuration (release identifier and artifact path) for middleware and OSS middleware feeds.
Changes:
- Update
RELEASE_NUMto a ticket-based identifier. - Change middleware IPK feed paths to point at debug artifact locations (
dbg/.../middleware-dbg/...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/oss_mw.inc | Switch default OSS middleware IPK feed path from release to debug artifacts. |
| conf/machine/include/middleware.inc | Update release identifier and core middleware IPK feed path to a debug artifact location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-16916" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The PR title/description indicates adding an AuthService API to clear a CDN access token, but this change set only updates Yocto IPK feed variables (RELEASE_NUM/MW_IPK_PATH). Either the PR description is incorrect or the implementation changes are missing from this PR; please align the description/title with the actual changes or include the intended code updates.
| RELEASE_NUM = "RDKEMW-16916" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_IPK_PATH was changed from "middleware-rel/${RELEASE_NUM}" to "dbg/${RELEASE_NUM}", but oss_mw.inc uses "middleware-dbg/${RELEASE_NUM}". This inconsistency will generate different base paths for core vs OSS middleware feeds and is likely to break one of the feed URLs. Consider using the same top-level directory naming scheme in both places (e.g., both "middleware-/..."), or derive the prefix from a single shared variable.
| MW_IPK_PATH ?= "dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
Changing the default MW_OSS_IPK_PATH from the release feed ("middleware-rel/..." previously) to "middleware-dbg/..." will redirect OSS middleware installs to debug artifacts by default. If debug feeds should only be used for specific build variants, consider selecting rel vs dbg based on BUILD_VARIANT (or a dedicated feature/flag) rather than changing the unconditional default.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_FEED ?= "${@'middleware-dbg' if 'dbg' in ((d.getVar('BUILD_VARIANT') or '').lower()) else 'middleware-rel'}" | |
| MW_OSS_IPK_PATH ?= "${MW_OSS_IPK_FEED}/${RELEASE_NUM}" |
Reason for change: add api that clears the CDN token from secure persistent location Test Procedure: see Jira ticket Risks: None Priority: P1 Signed-off-by: melhar098_comcast <Mahmoud_El-haron@comcast.com>
melhar098
force-pushed
the
feature/RDKEMW-16916
branch
from
1f2f947 to
07478f4
Compare
Reason for change: add api that clears the CDN token from secure persistent location
Test Procedure: see Jira ticket
Risks: None
Priority: P1