RDKEMW-16667: increase in TTS failures#78
Conversation
Reason for change: removing tts for system apps Test Procedure: Mentioned in ticket Risks: Low version: minor Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
There was a problem hiding this comment.
Pull request overview
Updates the middleware OPKG feed configuration to point at a different artifact location/release identifier, presumably to mitigate the “increase in TTS failures” by consuming a different middleware build.
Changes:
- Change middleware artifact “release” identifier from a version string to a ticket-scoped identifier.
- Switch middleware and OSS middleware IPK feed paths from
middleware-rel/...tomiddleware-dbg/....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Updates RELEASE_NUM and changes the middleware feed path to middleware-dbg. |
| conf/machine/include/oss_mw.inc | Changes OSS middleware feed path to middleware-dbg to match the new feed structure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.8" | ||
| RELEASE_NUM = "RDKEMW-16667" |
There was a problem hiding this comment.
RELEASE_NUM is being set to a ticket identifier ("RDKEMW-16667"), which makes the variable misleading and can reduce traceability/reproducibility compared to the prior version-like value. Consider keeping RELEASE_NUM as an actual release/version string and introducing a separate variable (e.g., an artifact tag/override) for ticket-scoped feeds, or make this value overridable via ?= if it’s intended to vary by build config.
| RELEASE_NUM = "RDKEMW-16667" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
Switching the default feed path from middleware-rel/... to middleware-dbg/... will make all images consume the debug artifact repository. If this is only intended for specific debug builds, gate it on an existing variant flag (e.g., BUILD_VARIANT) or keep middleware-rel as the default and override MW_IPK_PATH only where needed.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "${@'middleware-dbg/%s' % d.getVar('RELEASE_NUM') if d.getVar('BUILD_VARIANT') == 'dbg' else 'middleware-rel/%s' % d.getVar('RELEASE_NUM')}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This change points the OSS middleware feed at middleware-dbg/... instead of the previous middleware-rel/.... If production builds should remain on release artifacts, consider keeping middleware-rel as the default here and only overriding to middleware-dbg in debug-specific configurations.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" |
| RELEASE_NUM = "RDKEMW-16667" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The PR description mentions "removing tts for system apps", but the diff only updates middleware feed release/tag strings and switches from middleware-rel to middleware-dbg. Please align the PR description/title with the actual change (or include the TTS-related changes in this PR if they’re missing).
Reason for change: removing tts for system apps Test Procedure: Mentioned in ticket Risks: Low version: minor Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
Reason for change: removing tts for system apps
Test Procedure: Mentioned in ticket
Risks: Low
version: minor