RDKEMW-16179: Dobby patch for removing swap limits#72
RDKEMW-16179: Dobby patch for removing swap limits#72goruklu wants to merge 1 commit intosupport/8.4.4.0from
Conversation
Signed-off-by: Gurdal Oruklu <gurdal_oruklu@comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR repoints the Yocto middleware OPKG/IPK feed configuration to pull artifacts from a hotfix/debug location, presumably to consume a patched middleware/Dobby build.
Changes:
- Update
RELEASE_NUMto a hotfix identifier (hotfix/RDKEMW-16179). - Switch middleware and OSS IPK feed base paths from
middleware-rel/...tomiddleware-dbg/....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Points the main middleware feed to a hotfix release number and middleware-dbg artifact path. |
| conf/machine/include/oss_mw.inc | Points the OSS middleware feed to the same middleware-dbg artifact path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.8" | ||
| RELEASE_NUM = "hotfix/RDKEMW-16179" |
There was a problem hiding this comment.
RELEASE_NUM is now set to a hotfix branch-style value (hotfix/RDKEMW-16179) instead of a release version. Because this include is shared configuration, hardcoding a temporary hotfix identifier here makes the layer non-reproducible for other releases and may break downstream consumers that expect a numeric release (and the embedded / changes the feed URL structure). Consider making this overrideable (e.g., RELEASE_NUM ?= ...) and/or introducing a separate variable for hotfix feeds so production builds can keep using the normal release number by default.
| RELEASE_NUM = "hotfix/RDKEMW-16179" | |
| RELEASE_NUM ?= "hotfix/RDKEMW-16179" |
| RELEASE_NUM = "hotfix/RDKEMW-16179" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
Switching the default feed path from middleware-rel/... to middleware-dbg/... will redirect all middleware package feeds to the debug artifact area. Given this layer is named middleware-release (see conf/layer.conf), this looks like it could unintentionally pull non-release artifacts into normal builds. If this is only needed for the hotfix, consider scoping it (e.g., via a separate hotfix variable or a conditional) so the default remains the release feed.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | |
| MW_IPK_DEBUG_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
This changes the OSS middleware feed path to middleware-dbg/${RELEASE_NUM}. If middleware-dbg is intended only for debugging/hotfix validation, consider keeping OSS feeds on middleware-rel (or gating this change behind the same condition as the hotfix) to avoid pulling debug artifacts into standard images.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" |
| RELEASE_NUM = "hotfix/RDKEMW-16179" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
PR title mentions a "Dobby patch for removing swap limits", but the changes here only repoint middleware/OSS IPK feed URLs to a hotfix/debug location. If the swap-limit removal is expected to happen via the artifacts in that feed, it would help to clarify this in the PR description (or rename the PR) so reviewers can verify the right behavior is being pulled in.
No description provided.