Skip to content

RDKEMW-12532: Update middleware.inc#69

Open
arjunbinu wants to merge 1 commit intodevelopfrom
feature/RDKEMW-12532-tag1160
Open

RDKEMW-12532: Update middleware.inc#69
arjunbinu wants to merge 1 commit intodevelopfrom
feature/RDKEMW-12532-tag1160

Conversation

@arjunbinu
Copy link
Copy Markdown

No description provided.

@arjunbinu arjunbinu requested a review from a team as a code owner March 24, 2026 07:58
Copilot AI review requested due to automatic review settings March 24, 2026 07:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Yocto machine include that defines where middleware IPK feeds are fetched from.

Changes:

  • Repoints MW_IPK_SERVER_PATH to a middleware-dbg/RDKEMW-12532-build-test artifacts directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/middleware-dbg/RDKEMW-12532-build-test/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MW_IPK_SERVER_PATH is now hardcoded to a debug/test artifacts path (middleware-dbg/RDKEMW-12532-build-test/...), which will redirect all builds using this include to a ticket-specific location and likely break reproducibility once that directory is removed/rotated. This also makes MW_IPK_PATH unused. Please revert to composing the server path from ${MW_IPK_PATH} (as MW_OSS_IPK_SERVER_PATH does in oss_mw.inc) and, if a debug feed is needed, gate it behind a dedicated override variable (e.g., via local.conf/machine override) rather than baking a temporary path into the shared include.

Suggested change
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/middleware-dbg/RDKEMW-12532-build-test/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants