RDKEMW-14199: Moving AuthServiceHost configuration to the product layers#53
Open
sergiygladkyy wants to merge 1 commit intodevelopfrom
Open
RDKEMW-14199: Moving AuthServiceHost configuration to the product layers#53sergiygladkyy wants to merge 1 commit intodevelopfrom
sergiygladkyy wants to merge 1 commit intodevelopfrom
Conversation
Reason for change: AuthServiceHost (XACS URL) is currently defined in region configs and stamped at build time. Moving it to product layers enables per-device control and aligns with the FKPS migration (RDK-48642). Test Procedure: described in the ticket Implements: recipe changes Risks: No Source: COMCAST License: Apache-2.0 Upstream-Status: Pending Signed-off-by: Sergiy Gladkyy <sgladkyy@productengine.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Moves AuthServiceHost (XACS URL) handling out of region build-time stamping and into product-layer-controlled image assembly, aligning with the FKPS migration direction.
Changes:
- Updates image class documentation to reflect AuthService-related files.
- Enhances
authservice-config.bbclassto (a) optionally generate/etc/authservice/config.jsonfromBUILTIN_PARTNER_IDand (b) stamp/etc/rfcdefaults/authservice.iniwith AuthServiceHost.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| conf/include/image-classes.inc | Updates comment describing what the authservice-config image class installs/stamps. |
| classes/authservice-config.bbclass | Adds build-time stamping of authservice.ini plus conditional creation of config.json based on product-layer variables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: AuthServiceHost (XACS URL) is currently defined in region configs and stamped at build time. Moving it to product layers enables per-device control and aligns with the FKPS migration (RDK-48642).
Test Procedure: described in the ticket
Implements: recipe changes
Risks: No
Source: COMCAST
License: Apache-2.0
Upstream-Status: Pending