RDKEMW-14229: Fix RAM/swap reporting to use sysinfo mem_unit scaling#43
RDKEMW-14229: Fix RAM/swap reporting to use sysinfo mem_unit scaling#43nanimatta wants to merge 2 commits intosupport/8.4.4.0from
Conversation
nanimatta
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the middleware IPK feed configuration to point builds at a different artifact “release” identifier and repository path (likely for issue/branch-specific middleware artifacts).
Changes:
- Change
RELEASE_NUMfrom a fixed version string to"RDKEMW-14229". - Switch default middleware feed paths from
middleware-rel/...tomiddleware-dbg/...for both standard and OSS middleware feeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| conf/machine/include/middleware.inc | Updates RELEASE_NUM and changes default middleware IPK feed path to middleware-dbg/.... |
| conf/machine/include/oss_mw.inc | Changes default OSS middleware IPK feed path to middleware-dbg/.... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.4.4.5" | ||
| RELEASE_NUM = "RDKEMW-14229" |
There was a problem hiding this comment.
RELEASE_NUM is assigned with = to a ticket-like value ("RDKEMW-14229"), which makes the feed URL effectively hard-coded to this branch/issue and prevents overrides from distro/local configuration. Consider changing this to ?=/??= (and/or moving the issue-specific value to a machine/distro override) so normal builds can still point at the intended released middleware version without editing this include.
| RELEASE_NUM = "RDKEMW-14229" | |
| RELEASE_NUM ??= "RDKEMW-14229" |
| RELEASE_NUM = "RDKEMW-14229" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The default feed path was switched from middleware-rel/... to middleware-dbg/.... If middleware-dbg contains debug artifacts, making it the default can unintentionally pull debug packages into non-debug builds (and may not exist for all release variants). Consider keeping middleware-rel as the default and selecting the debug feed via an explicit build/machine/distro override when needed.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} " | ||
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The OSS middleware feed path default was changed to middleware-dbg/${RELEASE_NUM}. If this is meant only for debug/testing, consider leaving the default as the release feed and applying the debug path via an override so production builds don’t accidentally consume debug artifacts.
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_OSS_IPK_PATH ?= "middleware/${RELEASE_NUM}" |
No description provided.