Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the middleware configuration to use a development build identifier and debug artifact paths instead of the production release configuration. The changes modify the RELEASE_NUM from semantic version "8.5.1.0" to a JIRA ticket-based identifier "RDKEMW-12532-develop-r2", and switch the artifact source from release packages ("middleware-rel") to debug packages ("middleware-dbg").
Changes:
- Update RELEASE_NUM from semantic version "8.5.1.0" to JIRA-based identifier "RDKEMW-12532-develop-r2"
- Change MW_IPK_PATH from "middleware-rel" to "middleware-dbg" to use debug artifacts instead of release artifacts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-12532-develop-r0" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The combination of changing RELEASE_NUM to "RDKEMW-12532-develop-r2" and MW_IPK_PATH to "middleware-dbg" will result in the artifact path "middleware-dbg/RDKEMW-12532-develop-r2". This path format deviates from the standard versioning convention seen in the CHANGELOG.md where releases use semantic versioning (e.g., "8.5.1.0"). The oss_mw.inc file, which depends on RELEASE_NUM, will construct the path "middleware-rel/RDKEMW-12532-develop-r2", mixing release and development identifiers inconsistently. This could lead to artifact resolution failures if the artifacts are not published at these non-standard paths.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.5.1.0" | ||
| RELEASE_NUM = "RDKEMW-12532-develop-r0" |
There was a problem hiding this comment.
The RELEASE_NUM variable has been changed from a semantic version number "8.5.1.0" to a JIRA ticket identifier "RDKEMW-12532-develop-r2". This is inconsistent with the variable name "RELEASE_NUM" which implies a numeric release version. This change also breaks the expected path structure for artifact URLs, as release numbers typically follow semantic versioning conventions. If this is intended as a temporary development build identifier, consider using a separate variable or reverting to the semantic version format for production releases.
| RELEASE_NUM = "RDKEMW-12532-develop-r0" | |
| RELEASE_NUM = "8.5.1.0" |
| RELEASE_NUM = "RDKEMW-12532-develop-r0" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
The MW_IPK_PATH has been changed from "middleware-rel" (release) to "middleware-dbg" (debug). This change switches the artifact source from release packages to debug packages. This is a significant operational change that will affect all builds using this configuration. The oss_mw.inc file still references "middleware-rel/${RELEASE_NUM}" which will be inconsistent with this change. If this is intended for debugging purposes only, it should not be merged to the main branch. If this is a permanent change, the oss_mw.inc file should also be updated to use the debug path, or this change should be reverted.
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" |
No description provided.