RDKEMW-16778: ENT Service API for retrieving previous reboot info#8
RDKEMW-16778: ENT Service API for retrieving previous reboot info#8
Conversation
There was a problem hiding this comment.
Pull request overview
Adds test support for the new ENT DeviceDiagnostics API that retrieves “previous reboot” information by extending the existing GoogleMock-based IDeviceDiagnostics mock.
Changes:
- Extend
DeviceDiagnosticsMockwith aGetPreviousRebootInfo(...)mock method to match the updatedIDeviceDiagnosticsinterface.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MOCK_METHOD(void, AddRef, (), (const, override)); | ||
| MOCK_METHOD(uint32_t, Release, (), (const, override)); | ||
| MOCK_METHOD(void*, QueryInterface, (const uint32_t interfacenumber), (override)); | ||
| MOCK_METHOD(Core::hresult, GetPreviousRebootInfo, (RebootInfo& rebootInfo, bool& success),(override)); |
There was a problem hiding this comment.
Core::hresult and Exchange::IDeviceDiagnostics::RebootInfo are used here, but this header does not define namespace Core = WPEFramework::Core; / namespace Exchange = WPEFramework::Exchange; (nor using namespace WPEFramework;). This will fail to compile in configurations where those aliases are not provided transitively. Prefer using the already-imported hresult and IDeviceDiagnostics::RebootInfo (or add explicit namespace Core/Exchange aliases in this file).
| MOCK_METHOD(Core::hresult, GetPreviousRebootInfo, (RebootInfo& rebootInfo, bool& success),(override)); | |
| MOCK_METHOD(hresult, GetPreviousRebootInfo, (IDeviceDiagnostics::RebootInfo& rebootInfo, bool& success), (override)); |
No description provided.