RDKB-63887- MFPConfig is not set to "Optional" on all secure vAPs using WPA2-Personal by default when FeatureMFPConfig is enabled.#1051
Conversation
There was a problem hiding this comment.
Pull request overview
Updates TR-181 WiFi security mode handling so that when a VAP is configured for WPA2-Personal, the default Management Frame Protection (MFP/PMF) setting becomes “Optional” instead of “Disabled”, aligning with the reported RDKB-63887 behavior gap.
Changes:
- Changes default
mfpassignment for WPA/WPA2 personal security modes from Disabled to Optional whenModeEnabledis set.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case wifi_security_mode_wpa_personal: | ||
| l_security_cfg->u.key.type = wifi_security_key_type_psk; | ||
| l_security_cfg->mfp = wifi_mfp_cfg_disabled; | ||
| break; | ||
| case wifi_security_mode_wpa2_personal: | ||
| l_security_cfg->u.key.type = wifi_security_key_type_psk; | ||
| l_security_cfg->mfp = wifi_mfp_cfg_optional; | ||
| break; | ||
| case wifi_security_mode_wpa_wpa2_personal: | ||
| l_security_cfg->u.key.type = wifi_security_key_type_psk; | ||
| l_security_cfg->u.key.type = wifi_security_key_type_psk; |
There was a problem hiding this comment.
Indentation in the newly added case wifi_security_mode_wpa_personal / wifi_security_mode_wpa2_personal blocks uses tabs and is inconsistent with the surrounding 4-space indentation in this switch. Please reformat these lines to match the existing style to avoid churn in future diffs.
There was a problem hiding this comment.
@copilot apply changes based on this feedback
RDKB-63887- MFPConfig is not set to "Optional" on all secure vAPs using WPA2-Personal by default when FeatureMFPConfig is enabled.
Reason for change : Set MFP as optional for WPA2 personal security mode.
Test Procedure:
dmcli eRT getv Device.WiFi.AccessPoint.1.Security.ModeEnableddmcli eRT getv Device.WiFi.FeatureMFPConfigdmcli eRT getv Device.WiFi.AccessPoint.1.Security.MFPConfigPriority: P1
Risks: Low
Signed-off-by: Sneha Kannansneha_kannan@comcast.com